Source/core/rendering/RenderBlockLineLayout.cpp - Issue 255323004: Rendering text-justify:distribute for 8 bit characters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlockLineLayout.cpp

Issue 255323004: Rendering text-justify:distribute for 8 bit characters. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 3rd (WIP) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSPrimitiveValueMappings.h ('K') | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/style/RenderStyleConstants.h » ('j') | Source/platform/text/TextRun.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlockLineLayout.cpp

diff --git a/Source/core/rendering/RenderBlockLineLayout.cpp b/Source/core/rendering/RenderBlockLineLayout.cpp

index 2af240b4001c9fdb512000f54f99029c90a24748..a090da993d7b97816546055ae44e6d733538c273 100644

--- a/Source/core/rendering/RenderBlockLineLayout.cpp

+++ b/Source/core/rendering/RenderBlockLineLayout.cpp

@@ -597,9 +597,9 @@ BidiRun* RenderBlockFlow::computeInlineDirectionPositionsForSegment(RootInlineBo

toInlineTextBox(r->m_box)->setCanHaveLeadingExpansion(true);

unsigned opportunitiesInRun;

if (rt->is8Bit())

- opportunitiesInRun = Character::expansionOpportunityCount(rt->characters8() + r->m_start, r->m_stop - r->m_start, r->m_box->direction(), isAfterExpansion);

+ opportunitiesInRun = Character::expansionOpportunityCount(rt->characters8() + r->m_start, r->m_stop - r->m_start, r->m_box->direction(), isAfterExpansion, static_cast<TextJustifyStore>(textJustify));

else

- opportunitiesInRun = Character::expansionOpportunityCount(rt->characters16() + r->m_start, r->m_stop - r->m_start, r->m_box->direction(), isAfterExpansion);

+ opportunitiesInRun = Character::expansionOpportunityCount(rt->characters16() + r->m_start, r->m_stop - r->m_start, r->m_box->direction(), isAfterExpansion, static_cast<TextJustifyStore>(textJustify));

expansionOpportunities.append(opportunitiesInRun);

expansionOpportunityCount += opportunitiesInRun;

}