Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2553213002:
re-enabled netlog viewer dev server tests (Closed)
Descriptionre-enabled netlog viewer dev server tests
BUG=catapult:#2702
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0b2f00a285c60fa162112bcc0681549e90f4e267
Patch Set 1 #
Total comments: 2
Patch Set 2 : cleaned up code #Messages
Total messages: 19 (12 generated)
The CQ bit was checked by wangyix@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
sullivan@chromium.org changed reviewers: + sullivan@chromium.org
lgtm Looks like the presubmit is failing because there isn't a bug linked in the CL description. Can you edit the CL desription to: BUG=catapult:#2702? https://codereview.chromium.org/2553213002/diff/1/catapult_build/build_steps.py File catapult_build/build_steps.py (right): https://codereview.chromium.org/2553213002/diff/1/catapult_build/build_steps.... catapult_build/build_steps.py:169: 'disabled': ['android'], Can you also move the Netlog Viewer entry up so the list is sorted alphabetically?
Description was changed from ========== re-enabled netlog viewer dev server tests BUG=catapult:# ========== to ========== re-enabled netlog viewer dev server tests BUG=catapult:#2702 ==========
https://codereview.chromium.org/2553213002/diff/1/catapult_build/build_steps.py File catapult_build/build_steps.py (right): https://codereview.chromium.org/2553213002/diff/1/catapult_build/build_steps.... catapult_build/build_steps.py:169: 'disabled': ['android'], On 2016/12/06 19:17:01, sullivan wrote: > Can you also move the Netlog Viewer entry up so the list is sorted > alphabetically? Done.
The CQ bit was checked by wangyix@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org Link to the patchset: https://codereview.chromium.org/2553213002/#ps20001 (title: "cleaned up code")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Li...)
The CQ bit was checked by wangyix@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481056692242560,
"parent_rev": "cdad45e7732bb75b8b4204acd9284af90b98b11e", "commit_rev":
"0b2f00a285c60fa162112bcc0681549e90f4e267"}
Message was sent while issue was closed.
Description was changed from ========== re-enabled netlog viewer dev server tests BUG=catapult:#2702 ========== to ========== re-enabled netlog viewer dev server tests BUG=catapult:#2702 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2566583003/ by nednguyen@google.com. The reason for reverting is: Netlog test is failing, blocking catapult CQ: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma.... |
