Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2553203002: Move the linter core to the analyzer package (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov, pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missed files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1796 lines, -8 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/linter/linter.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/linter/linter_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/analysis.dart View 1 1 chunk +262 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/config.dart View 1 1 chunk +243 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/io.dart View 1 1 chunk +68 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/linter.dart View 1 1 chunk +429 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/project.dart View 1 1 chunk +129 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/pub.dart View 1 1 chunk +430 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/registry.dart View 1 1 chunk +42 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/lint/util.dart View 1 1 chunk +172 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
This adds all the files removed from the linter to analyzer, updates references to the ...
4 years ago (2016-12-06 17:32:56 UTC) #2
scheglov
lgtm
4 years ago (2016-12-06 17:36:49 UTC) #3
Brian Wilkerson
Committed patchset #2 (id:20001) manually as 6d9d5f53a12e5812bb938bfa608b3e40dbe306c6 (presubmit successful).
4 years ago (2016-12-06 17:42:31 UTC) #5
Paul Berry
On 2016/12/06 17:42:31, Brian Wilkerson wrote: > Committed patchset #2 (id:20001) manually as > 6d9d5f53a12e5812bb938bfa608b3e40dbe306c6 ...
4 years ago (2016-12-06 20:35:17 UTC) #6
Paul Berry
4 years ago (2016-12-07 13:48:16 UTC) #7
Message was sent while issue was closed. 
On 2016/12/06 20:35:17, Paul Berry wrote:
> On 2016/12/06 17:42:31, Brian Wilkerson wrote:
> > Committed patchset #2 (id:20001) manually as
> > 6d9d5f53a12e5812bb938bfa608b3e40dbe306c6 (presubmit successful).
> 
> It looks like this change broke some analysis server unit tests.  See for
> example
>
https://build.chromium.org/p/client.dart/builders/analyzer-mac10.11-release-b...
> 
> Would you mind having a look?

Note: I went ahead and reverted the CL for now:
https://codereview.chromium.org/2561573003/

Powered by Google App Engine
This is Rietveld 408576698