Move WebMediaPlayer to frame loading queue.

Expose per-frame task runners in WebLocalFrame.

Per blink per-frame task queues effort, expose task runners in WebLocalFrame
to be able to post tasks to appropriate frame-specific queues from outside
blink.

This patch also makes WebMediaPlayer post tasks to frame loading queue
instead of renderer default queue.

R=haraken@chromium.org,dalecurtis@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
BUG=624696
Committed: https://crrev.com/bf328384d2995fc20693e606522db157897e2b20
Cr-Commit-Position: refs/heads/master@{#436945}

[altimin, 2016-12-06 19:27:37]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[altimin, 2016-12-06 19:27:40]

PTAL

[commit-bot: I haz the power, 2016-12-06 19:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 19:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 19:39:30]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[DaleCurtis, 2016-12-06 20:11:05]

Hmm, will this work? Is this a separate thread? WMPI is not thread safe, so we
expect HTMLMediaElement to make all of it's calls on the same thread as
|main_task_runner_|. Are you changing HTMLME to run on this thread too?

[altimin, 2016-12-06 22:28:38]

On 2016/12/06 20:11:05, DaleCurtis wrote:
> Hmm, will this work? Is this a separate thread? WMPI is not thread safe, so we
> expect HTMLMediaElement to make all of it's calls on the same thread as
> |main_task_runner_|. Are you changing HTMLME to run on this thread too?

Sorry, I should have mentioned this explicitly: this will not change thread, it
is still going to be run on
renderer main thread. But it will post the task to frame-specific scheduler task
queue, which will give
scheduler more flexibility (for example, to prioritise main frame vs third-party
iframes).

[DaleCurtis, 2016-12-06 22:29:59]

lgtm

Seems okay then; presumably ordering is still guaranteed.

[haraken, 2016-12-07 00:19:26]

https://codereview.chromium.org/2553173003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2553173003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:193:
blink::TaskRunnerHelper::get(blink::TaskType::Media, frame)),

How can media/blink access TaskRunnerHelper?

https://codereview.chromium.org/2553173003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TaskRunnerHelper.h (right):

https://codereview.chromium.org/2553173003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TaskRunnerHelper.h:36: Media,

Is this speced somewhere?

[altimin, 2016-12-07 12:10:46]

Description was changed from

==========
Move WebMediaPlayer to frame loading queue.

Per blink per-frame task queues effort, make WebMediaPlayer to post tasks
to frame loading queue instead of default one.

R=haraken@chromium.org,dalecurtis@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
BUG=624696
==========

to

==========
Expose per-frame task runners in WebLocalFrame.

Per blink per-frame task queues effort, expose task runners in WebLocalFrame
to be able to post tasks to appropriate frame-specific queues from outside
blink.

This patch also makes WebMediaPlayer post tasks to frame loading queue
instead of renderer default queue.

R=haraken@chromium.org,dalecurtis@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
BUG=624696
==========

[altimin, 2016-12-07 12:10:56]

PTAL

https://codereview.chromium.org/2553173003/diff/1/media/blink/webmediaplayer_...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/2553173003/diff/1/media/blink/webmediaplayer_...
media/blink/webmediaplayer_impl.cc:193:
blink::TaskRunnerHelper::get(blink::TaskType::Media, frame)),
On 2016/12/07 00:19:26, haraken wrote:
> 
> How can media/blink access TaskRunnerHelper?

Acknowledged.

https://codereview.chromium.org/2553173003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/TaskRunnerHelper.h (right):

https://codereview.chromium.org/2553173003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/TaskRunnerHelper.h:36: Media,
On 2016/12/07 00:19:26, haraken wrote:
> 
> Is this speced somewhere?

Acknowledged.

[altimin, 2016-12-07 12:11:18]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 12:11:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-12-07 12:18:24]

LGTM

[commit-bot: I haz the power, 2016-12-07 14:21:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 14:21:43]

Dry run: This issue passed the CQ dry run.

[altimin, 2016-12-07 14:24:39]

The CQ bit was checked by altimin@chromium.org

[altimin, 2016-12-07 14:24:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2553173003/#ps20001
(title: "Expose task runners in WebLocalFrame")

[commit-bot: I haz the power, 2016-12-07 14:24:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 14:28:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481120679137380,
"parent_rev": "e1fb1ab8a96540124169b73a3d4835b7ac16ce18", "commit_rev":
"30f969241edb7523fadbe01fd5f9c02ec74ddaad"}

[commit-bot: I haz the power, 2016-12-07 14:29:01]

Description was changed from

==========
Expose per-frame task runners in WebLocalFrame.

Per blink per-frame task queues effort, expose task runners in WebLocalFrame
to be able to post tasks to appropriate frame-specific queues from outside
blink.

This patch also makes WebMediaPlayer post tasks to frame loading queue
instead of renderer default queue.

R=haraken@chromium.org,dalecurtis@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
BUG=624696
==========

to

==========
Expose per-frame task runners in WebLocalFrame.

Per blink per-frame task queues effort, expose task runners in WebLocalFrame
to be able to post tasks to appropriate frame-specific queues from outside
blink.

This patch also makes WebMediaPlayer post tasks to frame loading queue
instead of renderer default queue.

R=haraken@chromium.org,dalecurtis@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
BUG=624696
==========

[commit-bot: I haz the power, 2016-12-07 14:29:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-07 14:32:05]

Description was changed from

==========
Expose per-frame task runners in WebLocalFrame.

Per blink per-frame task queues effort, expose task runners in WebLocalFrame
to be able to post tasks to appropriate frame-specific queues from outside
blink.

This patch also makes WebMediaPlayer post tasks to frame loading queue
instead of renderer default queue.

R=haraken@chromium.org,dalecurtis@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
BUG=624696
==========

to

==========
Expose per-frame task runners in WebLocalFrame.

Per blink per-frame task queues effort, expose task runners in WebLocalFrame
to be able to post tasks to appropriate frame-specific queues from outside
blink.

This patch also makes WebMediaPlayer post tasks to frame loading queue
instead of renderer default queue.

R=haraken@chromium.org,dalecurtis@chromium.org
CC=alexclarke@chromium.org,skyostil@chromium.org
BUG=624696

Committed: https://crrev.com/bf328384d2995fc20693e606522db157897e2b20
Cr-Commit-Position: refs/heads/master@{#436945}
==========

[commit-bot: I haz the power, 2016-12-07 14:32:06]

Patchset 2 (id:??) landed as
https://crrev.com/bf328384d2995fc20693e606522db157897e2b20
Cr-Commit-Position: refs/heads/master@{#436945}