Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentAppManager.h

Issue 2553163003: Remove ContextLifecycleObserver from PaymentAppManager (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/payments/PaymentAppManager.h
diff --git a/third_party/WebKit/Source/modules/payments/PaymentAppManager.h b/third_party/WebKit/Source/modules/payments/PaymentAppManager.h
index d311af46b94cbb4c36323331fe9db7d616e2247b..7e9b3d99dd2e4013c93cafc5315c59eeb4d4ab80 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentAppManager.h
+++ b/third_party/WebKit/Source/modules/payments/PaymentAppManager.h
@@ -8,13 +8,11 @@
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "components/payments/payment_app.mojom-blink.h"
-#include "core/dom/ContextLifecycleObserver.h"
#include "modules/ModulesExport.h"
#include "platform/heap/Handle.h"
namespace blink {
-class ExecutionContext;
class PaymentAppManifest;
class ScriptPromiseResolver;
class ScriptState;
@@ -22,17 +20,12 @@ class ServiceWorkerRegistration;
class MODULES_EXPORT PaymentAppManager final
: public GarbageCollectedFinalized<PaymentAppManager>,
- public ScriptWrappable,
- public ContextLifecycleObserver {
+ public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
- USING_GARBAGE_COLLECTED_MIXIN(PaymentAppManager);
WTF_MAKE_NONCOPYABLE(PaymentAppManager);
public:
- static PaymentAppManager* create(ExecutionContext*,
- ServiceWorkerRegistration*);
-
- void contextDestroyed() override;
+ static PaymentAppManager* create(ServiceWorkerRegistration*);
ScriptPromise setManifest(ScriptState*, const PaymentAppManifest&);
ScriptPromise getManifest(ScriptState*);
@@ -40,7 +33,7 @@ class MODULES_EXPORT PaymentAppManager final
DECLARE_TRACE();
private:
- PaymentAppManager(ExecutionContext*, ServiceWorkerRegistration*);
+ explicit PaymentAppManager(ServiceWorkerRegistration*);
void onSetManifest(ScriptPromiseResolver*,
payments::mojom::blink::PaymentAppManifestError);
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698