Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp

Issue 2553163003: Remove ContextLifecycleObserver from PaymentAppManager (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp b/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
index e066fab743afaa999b44ac896054c0f1d5d65267..629cc301f2158a22467137f19fe7e2a42283a10b 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
@@ -84,13 +84,8 @@ struct TypeConverter<blink::PaymentAppOption, PaymentAppOptionPtr> {
namespace blink {
PaymentAppManager* PaymentAppManager::create(
- ExecutionContext* executionContext,
ServiceWorkerRegistration* registration) {
- return new PaymentAppManager(executionContext, registration);
-}
-
-void PaymentAppManager::contextDestroyed() {
- m_manager.reset();
+ return new PaymentAppManager(registration);
}
ScriptPromise PaymentAppManager::setManifest(
@@ -135,12 +130,10 @@ ScriptPromise PaymentAppManager::getManifest(ScriptState* scriptState) {
DEFINE_TRACE(PaymentAppManager) {
visitor->trace(m_registration);
- ContextLifecycleObserver::trace(visitor);
}
-PaymentAppManager::PaymentAppManager(ExecutionContext* executionContext,
- ServiceWorkerRegistration* registration)
- : ContextLifecycleObserver(executionContext), m_registration(registration) {
+PaymentAppManager::PaymentAppManager(ServiceWorkerRegistration* registration)
+ : m_registration(registration) {
DCHECK(registration);
Platform::current()->interfaceProvider()->getInterface(
mojo::GetProxy(&m_manager));

Powered by Google App Engine
This is Rietveld 408576698