third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 2553133002: Better isPageLogicalHeightKnown() implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 2553133002: Better isPageLogicalHeightKnown() implementation. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 479220102872e5d8bee46d5492922ed2bde5fcb6..82a3d6058de10a43d099b689afd1c26ae0af6189 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -507,10 +507,6 @@ class CORE_EXPORT LayoutBlock : public LayoutBox {

bool widthAvailableToChildrenHasChanged();

protected:

- bool isPageLogicalHeightKnown() const {

- return pageLogicalHeightForOffset(LayoutUnit());

- }

// Paginated content inside this block was laid out.

// |logicalBottomOffsetAfterPagination| is the logical bottom offset of the

// child content after applying any forced or unforced breaks as needed.