Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2553133002: Better isPageLogicalHeightKnown() implementation. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Better isPageLogicalHeightKnown() implementation. Need to consult the flow thread, if we have one. We may run into situations where fragmentainer groups in the first column set have got their height calculated, while later column sets still haven't calculated it [1]. So checking if flow thread offset 0 is in a fragmentainer of known height isn't good enough. Also moved the implementation from LayoutBlock to LayoutBox, since it's pretty coincidental that we currently don't need this particular method outside of LayoutBlock. [1] LayoutMultiColumnSet::recalculateColumnHeight() may reset the column heights if it detects that the column set has been moved since previous layout pass. BUG=670902 Committed: https://crrev.com/95342a4986af56783818b4a7f578f4b3b2bf5f2b Cr-Commit-Position: refs/heads/master@{#437063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/nested-with-spanner-and-margin-crash.html View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mstensho (USE GERRIT)
4 years ago (2016-12-06 16:40:55 UTC) #6
szager1
lgtm
4 years ago (2016-12-07 18:31:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553133002/1
4 years ago (2016-12-07 19:10:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 21:20:15 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 21:23:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95342a4986af56783818b4a7f578f4b3b2bf5f2b
Cr-Commit-Position: refs/heads/master@{#437063}

Powered by Google App Engine
This is Rietveld 408576698