Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 2553123002: [wasm] Honor the names section for modules coming from asm.js. (Closed)

Created:
4 years ago by titzer
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Honor the names section for modules coming from asm.js. R=bradnelson@chromium.org,clemensh@chromium.org BUG= Committed: https://crrev.com/400b01ffe7faa750e897fc83bdb6d1126114c27b Cr-Commit-Position: refs/heads/master@{#41528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M src/wasm/wasm-module.cc View 2 chunks +18 lines, -3 lines 0 comments Download
A test/mjsunit/wasm/asm-wasm-names.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
titzer
4 years ago (2016-12-06 14:05:37 UTC) #1
bradnelson
Oh, awesome, I was gonna get to this, but you beat me to it! lgtm
4 years ago (2016-12-06 14:07:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553123002/1
4 years ago (2016-12-06 14:09:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 14:31:30 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 14:32:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/400b01ffe7faa750e897fc83bdb6d1126114c27b
Cr-Commit-Position: refs/heads/master@{#41528}

Powered by Google App Engine
This is Rietveld 408576698