Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: third_party/WebKit/Source/core/layout/IntersectionGeometry.cpp

Issue 2553103004: Refactor IntersectionGeometry class and move it to core/layout. (Closed)
Patch Set: Simplify isContainingBlockChainDescendant Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/IntersectionGeometry.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/IntersectionGeometry.h" 5 #include "core/layout/IntersectionGeometry.h"
6 6
7 #include "core/dom/Element.h"
8 #include "core/dom/ElementRareData.h"
9 #include "core/frame/FrameView.h" 7 #include "core/frame/FrameView.h"
10 #include "core/frame/LocalFrame.h" 8 #include "core/frame/LocalFrame.h"
9 #include "core/html/HTMLFrameOwnerElement.h"
11 #include "core/layout/LayoutBox.h" 10 #include "core/layout/LayoutBox.h"
12 #include "core/layout/LayoutView.h" 11 #include "core/layout/LayoutView.h"
13 #include "core/layout/api/LayoutAPIShim.h" 12 #include "core/layout/api/LayoutAPIShim.h"
14 #include "core/layout/api/LayoutViewItem.h" 13 #include "core/layout/api/LayoutViewItem.h"
15 #include "core/paint/PaintLayer.h" 14 #include "core/paint/PaintLayer.h"
16 15
17 namespace blink { 16 namespace blink {
18 17
19 namespace { 18 namespace {
20 19
21 bool isContainingBlockChainDescendant(LayoutObject* descendant, 20 bool isContainingBlockChainDescendant(LayoutObject* descendant,
22 LayoutObject* ancestor) { 21 LayoutObject* ancestor) {
23 LocalFrame* ancestorFrame = ancestor->document().frame(); 22 LocalFrame* ancestorFrame = ancestor->document().frame();
24 LocalFrame* descendantFrame = descendant->document().frame(); 23 LocalFrame* descendantFrame = descendant->document().frame();
25
26 if (ancestor->isLayoutView())
27 return descendantFrame && descendantFrame->tree().top() == ancestorFrame;
28
29 if (ancestorFrame != descendantFrame) 24 if (ancestorFrame != descendantFrame)
30 return false; 25 return false;
31 26
32 while (descendant && descendant != ancestor) 27 while (descendant && descendant != ancestor)
33 descendant = descendant->containingBlock(); 28 descendant = descendant->containingBlock();
34 return descendant; 29 return descendant;
35 } 30 }
36 31
37 void mapRectUpToDocument(LayoutRect& rect, 32 void mapRectUpToDocument(LayoutRect& rect,
38 const LayoutObject& layoutObject, 33 const LayoutObject& descendant,
39 const Document& document) { 34 const Document& document) {
40 FloatQuad mappedQuad = layoutObject.localToAbsoluteQuad( 35 FloatQuad mappedQuad = descendant.localToAncestorQuad(
41 FloatQuad(FloatRect(rect)), UseTransforms | ApplyContainerFlip); 36 FloatQuad(FloatRect(rect)), document.layoutView(),
37 UseTransforms | ApplyContainerFlip);
42 rect = LayoutRect(mappedQuad.boundingBox()); 38 rect = LayoutRect(mappedQuad.boundingBox());
43 } 39 }
44 40
45 void mapRectDownToDocument(LayoutRect& rect, 41 void mapRectDownToDocument(LayoutRect& rect,
46 LayoutBoxModelObject& layoutObject, 42 LayoutBoxModelObject* ancestor,
47 const Document& document) { 43 const Document& document) {
48 FloatQuad mappedQuad = document.layoutView()->ancestorToLocalQuad( 44 FloatQuad mappedQuad = document.layoutView()->ancestorToLocalQuad(
49 &layoutObject, FloatQuad(FloatRect(rect)), 45 ancestor, FloatQuad(FloatRect(rect)),
50 UseTransforms | ApplyContainerFlip | TraverseDocumentBoundaries); 46 UseTransforms | ApplyContainerFlip | TraverseDocumentBoundaries);
51 rect = LayoutRect(mappedQuad.boundingBox()); 47 rect = LayoutRect(mappedQuad.boundingBox());
52 } 48 }
53 49
54 LayoutUnit computeMargin(const Length& length, LayoutUnit referenceLength) { 50 LayoutUnit computeMargin(const Length& length, LayoutUnit referenceLength) {
55 if (length.type() == Percent) { 51 if (length.type() == Percent) {
56 return LayoutUnit( 52 return LayoutUnit(
57 static_cast<int>(referenceLength.toFloat() * length.percent() / 100.0)); 53 static_cast<int>(referenceLength.toFloat() * length.percent() / 100.0));
58 } 54 }
59 DCHECK_EQ(length.type(), Fixed); 55 DCHECK_EQ(length.type(), Fixed);
60 return LayoutUnit(length.intValue()); 56 return LayoutUnit(length.intValue());
61 } 57 }
62 58
59 LayoutView* localRootView(Element& element) {
60 LocalFrame* frame = element.document().frame();
61 LocalFrame* frameRoot = frame ? frame->localFrameRoot() : nullptr;
62 return frameRoot ? frameRoot->contentLayoutObject() : nullptr;
63 }
64
63 } // namespace 65 } // namespace
64 66
65 IntersectionGeometry::IntersectionGeometry( 67 IntersectionGeometry::IntersectionGeometry(Element* root,
66 Node* root, 68 Element& target,
67 Element* target, 69 const Vector<Length>& rootMargin,
68 const Vector<Length>& rootMargin, 70 bool shouldReportRootBounds)
69 ReportRootBounds shouldReportRootBounds) 71 : m_root(root ? root->layoutObject() : localRootView(target)),
70 : m_root(root), 72 m_target(target.layoutObject()),
71 m_target(target),
72 m_rootMargin(rootMargin), 73 m_rootMargin(rootMargin),
73 m_shouldReportRootBounds(shouldReportRootBounds) { 74 m_doesIntersect(0),
74 DCHECK(m_target); 75 m_shouldReportRootBounds(shouldReportRootBounds),
75 DCHECK(rootMargin.isEmpty() || rootMargin.size() == 4); 76 m_rootIsImplicit(!root),
77 m_canComputeGeometry(initializeCanComputeGeometry(root, target)) {
78 if (m_canComputeGeometry)
79 initializeGeometry();
76 } 80 }
77 81
78 IntersectionGeometry::~IntersectionGeometry() {} 82 IntersectionGeometry::~IntersectionGeometry() {}
79 83
80 Element* IntersectionGeometry::root() const { 84 bool IntersectionGeometry::initializeCanComputeGeometry(Element* root,
81 if (m_root && !m_root->isDocumentNode()) 85 Element& target) const {
82 return toElement(m_root); 86 DCHECK(m_rootMargin.isEmpty() || m_rootMargin.size() == 4);
83 return nullptr; 87 if (root && !root->isConnected())
84 } 88 return false;
85 89 if (!m_root || !m_root->isBox())
86 LayoutObject* IntersectionGeometry::getRootLayoutObject() const { 90 return false;
87 DCHECK(m_root); 91 if (!target.isConnected())
88 if (m_root->isDocumentNode()) { 92 return false;
89 return LayoutAPIShim::layoutObjectFrom( 93 if (!m_target || (!m_target->isBoxModelObject() && !m_target->isText()))
90 toDocument(m_root)->layoutViewItem()); 94 return false;
91 } 95 if (root && !isContainingBlockChainDescendant(m_target, m_root))
92 return toElement(m_root)->layoutObject(); 96 return false;
97 return true;
93 } 98 }
94 99
95 void IntersectionGeometry::initializeGeometry() { 100 void IntersectionGeometry::initializeGeometry() {
96 initializeTargetRect(); 101 initializeTargetRect();
97 m_intersectionRect = m_targetRect; 102 m_intersectionRect = m_targetRect;
98 initializeRootRect(); 103 initializeRootRect();
99 m_doesIntersect = true;
100 } 104 }
101 105
102 void IntersectionGeometry::initializeTargetRect() { 106 void IntersectionGeometry::initializeTargetRect() {
103 LayoutObject* targetLayoutObject = m_target->layoutObject(); 107 m_targetRect =
104 DCHECK(targetLayoutObject && targetLayoutObject->isBoxModelObject()); 108 LayoutRect(toLayoutBoxModelObject(target())->borderBoundingBox());
105 m_targetRect = LayoutRect(
106 toLayoutBoxModelObject(targetLayoutObject)->borderBoundingBox());
107 } 109 }
108 110
109 void IntersectionGeometry::initializeRootRect() { 111 void IntersectionGeometry::initializeRootRect() {
110 LayoutObject* rootLayoutObject = getRootLayoutObject(); 112 // TODO(szager): In OOPIF, m_root will be the LayoutView of the
111 if (rootLayoutObject->isLayoutView()) { 113 // localFrameRoot(). Once viewport intersection support lands,
112 m_rootRect = LayoutRect( 114 // add a call to mapToVisualRectInAncestorSpace to map the rect up to
113 toLayoutView(rootLayoutObject)->frameView()->visibleContentRect()); 115 // top-level frame coordinates.
114 } else if (rootLayoutObject->isBox() && rootLayoutObject->hasOverflowClip()) { 116 if (m_root->isLayoutView()) {
115 m_rootRect = LayoutRect(toLayoutBox(rootLayoutObject)->contentBoxRect()); 117 m_rootRect =
118 LayoutRect(toLayoutView(m_root)->frameView()->visibleContentRect());
119 } else if (m_root->isBox() && m_root->hasOverflowClip()) {
120 m_rootRect = LayoutRect(toLayoutBox(m_root)->contentBoxRect());
116 } else { 121 } else {
117 m_rootRect = LayoutRect( 122 m_rootRect =
118 toLayoutBoxModelObject(rootLayoutObject)->borderBoundingBox()); 123 LayoutRect(toLayoutBoxModelObject(m_root)->borderBoundingBox());
119 } 124 }
120 applyRootMargin(); 125 applyRootMargin();
121 } 126 }
122 127
123 void IntersectionGeometry::applyRootMargin() { 128 void IntersectionGeometry::applyRootMargin() {
124 if (m_rootMargin.isEmpty()) 129 if (m_rootMargin.isEmpty())
125 return; 130 return;
126 131
127 // TODO(szager): Make sure the spec is clear that left/right margins are 132 // TODO(szager): Make sure the spec is clear that left/right margins are
128 // resolved against width and not height. 133 // resolved against width and not height.
129 LayoutUnit topMargin = computeMargin(m_rootMargin[0], m_rootRect.height()); 134 LayoutUnit topMargin = computeMargin(m_rootMargin[0], m_rootRect.height());
130 LayoutUnit rightMargin = computeMargin(m_rootMargin[1], m_rootRect.width()); 135 LayoutUnit rightMargin = computeMargin(m_rootMargin[1], m_rootRect.width());
131 LayoutUnit bottomMargin = computeMargin(m_rootMargin[2], m_rootRect.height()); 136 LayoutUnit bottomMargin = computeMargin(m_rootMargin[2], m_rootRect.height());
132 LayoutUnit leftMargin = computeMargin(m_rootMargin[3], m_rootRect.width()); 137 LayoutUnit leftMargin = computeMargin(m_rootMargin[3], m_rootRect.width());
133 138
134 m_rootRect.setX(m_rootRect.x() - leftMargin); 139 m_rootRect.setX(m_rootRect.x() - leftMargin);
135 m_rootRect.setWidth(m_rootRect.width() + leftMargin + rightMargin); 140 m_rootRect.setWidth(m_rootRect.width() + leftMargin + rightMargin);
136 m_rootRect.setY(m_rootRect.y() - topMargin); 141 m_rootRect.setY(m_rootRect.y() - topMargin);
137 m_rootRect.setHeight(m_rootRect.height() + topMargin + bottomMargin); 142 m_rootRect.setHeight(m_rootRect.height() + topMargin + bottomMargin);
138 } 143 }
139 144
140 void IntersectionGeometry::clipToRoot() { 145 void IntersectionGeometry::clipToRoot() {
141 // Map and clip rect into root element coordinates. 146 // Map and clip rect into root element coordinates.
142 // TODO(szager): the writing mode flipping needs a test. 147 // TODO(szager): the writing mode flipping needs a test.
143 LayoutBox* rootLayoutObject = toLayoutBox(getRootLayoutObject()); 148 // TODO(szager): Once the OOPIF viewport intersection code lands,
144 LayoutObject* targetLayoutObject = m_target->layoutObject(); 149 // use nullptr for ancestor to map to the top frame.
145 150 LayoutBox* ancestor = toLayoutBox(m_root);
146 m_doesIntersect = targetLayoutObject->mapToVisualRectInAncestorSpace( 151 m_doesIntersect = m_target->mapToVisualRectInAncestorSpace(
147 rootLayoutObject, m_intersectionRect, EdgeInclusive); 152 ancestor, m_intersectionRect, EdgeInclusive);
148 if (rootLayoutObject->hasOverflowClip()) 153 if (ancestor && ancestor->hasOverflowClip())
149 m_intersectionRect.move(-rootLayoutObject->scrolledContentOffset()); 154 m_intersectionRect.move(-ancestor->scrolledContentOffset());
150
151 if (!m_doesIntersect) 155 if (!m_doesIntersect)
152 return; 156 return;
153 LayoutRect rootClipRect(m_rootRect); 157 LayoutRect rootClipRect(m_rootRect);
154 rootLayoutObject->flipForWritingMode(rootClipRect); 158 if (ancestor)
159 ancestor->flipForWritingMode(rootClipRect);
155 m_doesIntersect &= m_intersectionRect.inclusiveIntersect(rootClipRect); 160 m_doesIntersect &= m_intersectionRect.inclusiveIntersect(rootClipRect);
156 } 161 }
157 162
158 void IntersectionGeometry::mapTargetRectToTargetFrameCoordinates() { 163 void IntersectionGeometry::mapTargetRectToTargetFrameCoordinates() {
159 LayoutObject& targetLayoutObject = *m_target->layoutObject();
160 Document& targetDocument = m_target->document(); 164 Document& targetDocument = m_target->document();
161 LayoutSize scrollPosition = 165 LayoutSize scrollPosition =
162 LayoutSize(targetDocument.view()->getScrollOffset()); 166 LayoutSize(targetDocument.view()->getScrollOffset());
163 mapRectUpToDocument(m_targetRect, targetLayoutObject, targetDocument); 167 mapRectUpToDocument(m_targetRect, *m_target, targetDocument);
164 m_targetRect.move(-scrollPosition); 168 m_targetRect.move(-scrollPosition);
165 } 169 }
166 170
167 void IntersectionGeometry::mapRootRectToRootFrameCoordinates() { 171 void IntersectionGeometry::mapRootRectToRootFrameCoordinates() {
168 LayoutObject& rootLayoutObject = *getRootLayoutObject(); 172 Document& rootDocument = m_root->document();
169 Document& rootDocument = rootLayoutObject.document(); 173 if (!rootIsImplicit())
174 mapRectUpToDocument(m_rootRect, *m_root, rootDocument);
175 // TODO(szager): When OOPIF support lands, this scroll offset adjustment
176 // will probably be wrong.
170 LayoutSize scrollPosition = 177 LayoutSize scrollPosition =
171 LayoutSize(rootDocument.view()->getScrollOffset()); 178 LayoutSize(rootDocument.view()->getScrollOffset());
172 mapRectUpToDocument(m_rootRect, rootLayoutObject,
173 rootLayoutObject.document());
174 m_rootRect.move(-scrollPosition); 179 m_rootRect.move(-scrollPosition);
175 } 180 }
176 181
177 void IntersectionGeometry::mapRootRectToTargetFrameCoordinates() { 182 void IntersectionGeometry::mapIntersectionRectToTargetFrameCoordinates() {
178 LayoutObject& rootLayoutObject = *getRootLayoutObject();
179 Document& targetDocument = m_target->document(); 183 Document& targetDocument = m_target->document();
180 LayoutSize scrollPosition = 184 if (rootIsImplicit()) {
181 LayoutSize(targetDocument.view()->getScrollOffset()); 185 LocalFrame* targetFrame = targetDocument.frame();
182 186 Frame* rootFrame = targetFrame->tree().top();
183 if (&targetDocument == &rootLayoutObject.document()) { 187 LayoutSize scrollPosition =
184 mapRectUpToDocument(m_intersectionRect, rootLayoutObject, targetDocument); 188 LayoutSize(targetDocument.view()->getScrollOffset());
189 if (targetFrame != rootFrame)
190 mapRectDownToDocument(m_intersectionRect, nullptr, targetDocument);
191 m_intersectionRect.move(-scrollPosition);
185 } else { 192 } else {
186 mapRectDownToDocument(m_intersectionRect, 193 LayoutSize scrollPosition =
187 toLayoutBoxModelObject(rootLayoutObject), 194 LayoutSize(targetDocument.view()->getScrollOffset());
188 targetDocument); 195 mapRectUpToDocument(m_intersectionRect, *m_root, m_root->document());
196 m_intersectionRect.move(-scrollPosition);
189 } 197 }
190
191 m_intersectionRect.move(-scrollPosition);
192 } 198 }
193 199
194 void IntersectionGeometry::computeGeometry() { 200 void IntersectionGeometry::computeGeometry() {
195 // In the first few lines here, before initializeGeometry is called, "return 201 if (!canComputeGeometry())
196 // true" effectively means "if the previous observed state was that root and
197 // target were intersecting, then generate a notification indicating that they
198 // are no longer intersecting." This happens, for example, when root or
199 // target is removed from the DOM tree and not reinserted before the next
200 // frame is generated, or display:none is set on the root or target.
201 if (!m_target->isConnected())
202 return; 202 return;
203 Element* rootElement = root();
204 if (rootElement && !rootElement->isConnected())
205 return;
206
207 LayoutObject* rootLayoutObject = getRootLayoutObject();
208 if (!rootLayoutObject || !rootLayoutObject->isBoxModelObject())
209 return;
210 // TODO(szager): Support SVG
211 LayoutObject* targetLayoutObject = m_target->layoutObject();
212 if (!targetLayoutObject)
213 return;
214 if (!targetLayoutObject->isBoxModelObject() && !targetLayoutObject->isText())
215 return;
216 if (!isContainingBlockChainDescendant(targetLayoutObject, rootLayoutObject))
217 return;
218
219 initializeGeometry();
220
221 clipToRoot(); 203 clipToRoot();
222
223 mapTargetRectToTargetFrameCoordinates(); 204 mapTargetRectToTargetFrameCoordinates();
224
225 if (m_doesIntersect) 205 if (m_doesIntersect)
226 mapRootRectToTargetFrameCoordinates(); 206 mapIntersectionRectToTargetFrameCoordinates();
227 else 207 else
228 m_intersectionRect = LayoutRect(); 208 m_intersectionRect = LayoutRect();
229
230 // Small optimization: if we're not going to report root bounds, don't bother 209 // Small optimization: if we're not going to report root bounds, don't bother
231 // transforming them to the frame. 210 // transforming them to the frame.
232 if (m_shouldReportRootBounds == ReportRootBounds::kShouldReportRootBounds) 211 if (shouldReportRootBounds())
233 mapRootRectToRootFrameCoordinates(); 212 mapRootRectToRootFrameCoordinates();
234 } 213 }
235 214
236 DEFINE_TRACE(IntersectionGeometry) {
237 visitor->trace(m_root);
238 visitor->trace(m_target);
239 }
240
241 } // namespace blink 215 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/IntersectionGeometry.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698