Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: third_party/WebKit/Source/core/layout/IntersectionGeometry.cpp

Issue 2553103004: Refactor IntersectionGeometry class and move it to core/layout. (Closed)
Patch Set: nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/IntersectionGeometry.h" 5 #include "core/layout/IntersectionGeometry.h"
6 6
7 #include "core/dom/Element.h"
8 #include "core/dom/ElementRareData.h"
9 #include "core/frame/FrameView.h" 7 #include "core/frame/FrameView.h"
10 #include "core/frame/LocalFrame.h" 8 #include "core/frame/LocalFrame.h"
9 #include "core/html/HTMLFrameOwnerElement.h"
11 #include "core/layout/LayoutBox.h" 10 #include "core/layout/LayoutBox.h"
12 #include "core/layout/LayoutView.h" 11 #include "core/layout/LayoutView.h"
13 #include "core/layout/api/LayoutAPIShim.h" 12 #include "core/layout/api/LayoutAPIShim.h"
14 #include "core/layout/api/LayoutViewItem.h" 13 #include "core/layout/api/LayoutViewItem.h"
15 #include "core/paint/PaintLayer.h" 14 #include "core/paint/PaintLayer.h"
16 15
17 namespace blink { 16 namespace blink {
18 17
19 namespace { 18 namespace {
20 19
21 bool isContainingBlockChainDescendant(LayoutObject* descendant, 20 bool isContainingBlockChainDescendant(LayoutObject* descendant,
22 LayoutObject* ancestor) { 21 LayoutObject* ancestor) {
23 LocalFrame* ancestorFrame = ancestor->document().frame(); 22 LocalFrame* ancestorFrame = ancestor->document().frame();
24 LocalFrame* descendantFrame = descendant->document().frame(); 23 LocalFrame* descendantFrame = descendant->document().frame();
24 if (!ancestorFrame)
25 return false;
26
27 while (descendantFrame && descendantFrame != ancestorFrame) {
28 HTMLFrameOwnerElement* owner = descendant->document().localOwner();
29 if (!owner)
30 return false;
31 descendant = owner->layoutObject();
32 if (!descendant)
33 return false;
34 descendantFrame = descendant->document().frame();
35 }
36
37 if (!descendantFrame)
38 return false;
25 39
26 if (ancestor->isLayoutView()) 40 if (ancestor->isLayoutView())
27 return descendantFrame && descendantFrame->tree().top() == ancestorFrame; 41 return true;
28
29 if (ancestorFrame != descendantFrame)
30 return false;
31 42
32 while (descendant && descendant != ancestor) 43 while (descendant && descendant != ancestor)
33 descendant = descendant->containingBlock(); 44 descendant = descendant->containingBlock();
34 return descendant; 45 return descendant;
35 } 46 }
36 47
37 void mapRectUpToDocument(LayoutRect& rect, 48 void mapRectUpToDocument(LayoutRect& rect,
38 const LayoutObject& layoutObject, 49 const LayoutObject& descendant,
39 const Document& document) { 50 const Document& document) {
40 FloatQuad mappedQuad = layoutObject.localToAbsoluteQuad( 51 FloatQuad mappedQuad = descendant.localToAncestorQuad(
41 FloatQuad(FloatRect(rect)), UseTransforms | ApplyContainerFlip); 52 FloatQuad(FloatRect(rect)), document.layoutView(),
53 UseTransforms | ApplyContainerFlip);
42 rect = LayoutRect(mappedQuad.boundingBox()); 54 rect = LayoutRect(mappedQuad.boundingBox());
43 } 55 }
44 56
45 void mapRectDownToDocument(LayoutRect& rect, 57 void mapRectDownToDocument(LayoutRect& rect,
46 LayoutBoxModelObject& layoutObject, 58 LayoutBoxModelObject* ancestor,
47 const Document& document) { 59 const Document& document) {
48 FloatQuad mappedQuad = document.layoutView()->ancestorToLocalQuad( 60 FloatQuad mappedQuad = document.layoutView()->ancestorToLocalQuad(
49 &layoutObject, FloatQuad(FloatRect(rect)), 61 ancestor, FloatQuad(FloatRect(rect)),
50 UseTransforms | ApplyContainerFlip | TraverseDocumentBoundaries); 62 UseTransforms | ApplyContainerFlip | TraverseDocumentBoundaries);
51 rect = LayoutRect(mappedQuad.boundingBox()); 63 rect = LayoutRect(mappedQuad.boundingBox());
52 } 64 }
53 65
54 LayoutUnit computeMargin(const Length& length, LayoutUnit referenceLength) { 66 LayoutUnit computeMargin(const Length& length, LayoutUnit referenceLength) {
55 if (length.type() == Percent) { 67 if (length.type() == Percent) {
56 return LayoutUnit( 68 return LayoutUnit(
57 static_cast<int>(referenceLength.toFloat() * length.percent() / 100.0)); 69 static_cast<int>(referenceLength.toFloat() * length.percent() / 100.0));
58 } 70 }
59 DCHECK_EQ(length.type(), Fixed); 71 DCHECK_EQ(length.type(), Fixed);
60 return LayoutUnit(length.intValue()); 72 return LayoutUnit(length.intValue());
61 } 73 }
62 74
75 LayoutView* localRootView(Element& element) {
76 LocalFrame* frame = element.document().frame();
77 LocalFrame* frameRoot = frame ? frame->localFrameRoot() : nullptr;
78 return frameRoot ? frameRoot->contentLayoutObject() : nullptr;
79 }
80
63 } // namespace 81 } // namespace
64 82
65 IntersectionGeometry::IntersectionGeometry( 83 IntersectionGeometry::IntersectionGeometry(Element* root,
66 Node* root, 84 Element& target,
67 Element* target, 85 const Vector<Length>& rootMargin,
68 const Vector<Length>& rootMargin, 86 bool shouldReportRootBounds)
69 ReportRootBounds shouldReportRootBounds) 87 : m_root(root ? root->layoutObject() : localRootView(target)),
70 : m_root(root), 88 m_target(target.layoutObject()),
71 m_target(target),
72 m_rootMargin(rootMargin), 89 m_rootMargin(rootMargin),
73 m_shouldReportRootBounds(shouldReportRootBounds) { 90 m_doesIntersect(0),
74 DCHECK(m_target); 91 m_shouldReportRootBounds(shouldReportRootBounds),
75 DCHECK(rootMargin.isEmpty() || rootMargin.size() == 4); 92 m_rootIsImplicit(!root),
93 m_isValid(canComputeGeometry(root, target)) {
94 if (m_isValid)
95 initializeGeometry();
76 } 96 }
77 97
78 IntersectionGeometry::~IntersectionGeometry() {} 98 IntersectionGeometry::~IntersectionGeometry() {}
79 99
80 Element* IntersectionGeometry::root() const { 100 bool IntersectionGeometry::canComputeGeometry(Element* root,
81 if (m_root && !m_root->isDocumentNode()) 101 Element& target) const {
82 return toElement(m_root); 102 DCHECK(m_rootMargin.isEmpty() || m_rootMargin.size() == 4);
83 return nullptr; 103 if (root && !root->isConnected())
84 } 104 return false;
85 105 if (!m_root || !m_root->isBox())
86 LayoutObject* IntersectionGeometry::getRootLayoutObject() const { 106 return false;
87 DCHECK(m_root); 107 if (!target.isConnected())
88 if (m_root->isDocumentNode()) { 108 return false;
89 return LayoutAPIShim::layoutObjectFrom( 109 if (!m_target || (!m_target->isBoxModelObject() && !m_target->isText()))
90 toDocument(m_root)->layoutViewItem()); 110 return false;
91 } 111 if (root && !isContainingBlockChainDescendant(m_target, m_root))
92 return toElement(m_root)->layoutObject(); 112 return false;
113 return true;
93 } 114 }
94 115
95 void IntersectionGeometry::initializeGeometry() { 116 void IntersectionGeometry::initializeGeometry() {
96 initializeTargetRect(); 117 initializeTargetRect();
97 m_intersectionRect = m_targetRect; 118 m_intersectionRect = m_targetRect;
98 initializeRootRect(); 119 initializeRootRect();
99 m_doesIntersect = true;
100 } 120 }
101 121
102 void IntersectionGeometry::initializeTargetRect() { 122 void IntersectionGeometry::initializeTargetRect() {
103 LayoutObject* targetLayoutObject = m_target->layoutObject(); 123 m_targetRect =
104 DCHECK(targetLayoutObject && targetLayoutObject->isBoxModelObject()); 124 LayoutRect(toLayoutBoxModelObject(target())->borderBoundingBox());
105 m_targetRect = LayoutRect(
106 toLayoutBoxModelObject(targetLayoutObject)->borderBoundingBox());
107 } 125 }
108 126
109 void IntersectionGeometry::initializeRootRect() { 127 void IntersectionGeometry::initializeRootRect() {
110 LayoutObject* rootLayoutObject = getRootLayoutObject(); 128 // TODO(szager): In OOPIF, m_root will be the LayoutView of the
111 if (rootLayoutObject->isLayoutView()) { 129 // localFrameRoot(). Once viewport intersection support lands,
112 m_rootRect = LayoutRect( 130 // add a call to mapToVisualRectInAncestorSpace to map the rect up to
113 toLayoutView(rootLayoutObject)->frameView()->visibleContentRect()); 131 // top-level frame coordinates.
114 } else if (rootLayoutObject->isBox() && rootLayoutObject->hasOverflowClip()) { 132 if (m_root->isLayoutView()) {
115 m_rootRect = LayoutRect(toLayoutBox(rootLayoutObject)->contentBoxRect()); 133 m_rootRect =
134 LayoutRect(toLayoutView(m_root)->frameView()->visibleContentRect());
135 } else if (m_root->isBox() && m_root->hasOverflowClip()) {
136 m_rootRect = LayoutRect(toLayoutBox(m_root)->contentBoxRect());
116 } else { 137 } else {
117 m_rootRect = LayoutRect( 138 m_rootRect =
118 toLayoutBoxModelObject(rootLayoutObject)->borderBoundingBox()); 139 LayoutRect(toLayoutBoxModelObject(m_root)->borderBoundingBox());
119 } 140 }
120 applyRootMargin(); 141 applyRootMargin();
121 } 142 }
122 143
123 void IntersectionGeometry::applyRootMargin() { 144 void IntersectionGeometry::applyRootMargin() {
124 if (m_rootMargin.isEmpty()) 145 if (m_rootMargin.isEmpty())
125 return; 146 return;
126 147
127 // TODO(szager): Make sure the spec is clear that left/right margins are 148 // TODO(szager): Make sure the spec is clear that left/right margins are
128 // resolved against width and not height. 149 // resolved against width and not height.
129 LayoutUnit topMargin = computeMargin(m_rootMargin[0], m_rootRect.height()); 150 LayoutUnit topMargin = computeMargin(m_rootMargin[0], m_rootRect.height());
130 LayoutUnit rightMargin = computeMargin(m_rootMargin[1], m_rootRect.width()); 151 LayoutUnit rightMargin = computeMargin(m_rootMargin[1], m_rootRect.width());
131 LayoutUnit bottomMargin = computeMargin(m_rootMargin[2], m_rootRect.height()); 152 LayoutUnit bottomMargin = computeMargin(m_rootMargin[2], m_rootRect.height());
132 LayoutUnit leftMargin = computeMargin(m_rootMargin[3], m_rootRect.width()); 153 LayoutUnit leftMargin = computeMargin(m_rootMargin[3], m_rootRect.width());
133 154
134 m_rootRect.setX(m_rootRect.x() - leftMargin); 155 m_rootRect.setX(m_rootRect.x() - leftMargin);
135 m_rootRect.setWidth(m_rootRect.width() + leftMargin + rightMargin); 156 m_rootRect.setWidth(m_rootRect.width() + leftMargin + rightMargin);
136 m_rootRect.setY(m_rootRect.y() - topMargin); 157 m_rootRect.setY(m_rootRect.y() - topMargin);
137 m_rootRect.setHeight(m_rootRect.height() + topMargin + bottomMargin); 158 m_rootRect.setHeight(m_rootRect.height() + topMargin + bottomMargin);
138 } 159 }
139 160
140 void IntersectionGeometry::clipToRoot() { 161 void IntersectionGeometry::clipToRoot() {
141 // Map and clip rect into root element coordinates. 162 // Map and clip rect into root element coordinates.
142 // TODO(szager): the writing mode flipping needs a test. 163 // TODO(szager): the writing mode flipping needs a test.
143 LayoutBox* rootLayoutObject = toLayoutBox(getRootLayoutObject()); 164 // TODO(szager): Once the OOPIF viewport intersection code lands,
144 LayoutObject* targetLayoutObject = m_target->layoutObject(); 165 // use nullptr for ancestor to map to the top frame.
145 166 LayoutBox* ancestor = toLayoutBox(m_root);
146 m_doesIntersect = targetLayoutObject->mapToVisualRectInAncestorSpace( 167 m_doesIntersect = m_target->mapToVisualRectInAncestorSpace(
147 rootLayoutObject, m_intersectionRect, EdgeInclusive); 168 ancestor, m_intersectionRect, EdgeInclusive);
148 if (rootLayoutObject->hasOverflowClip()) 169 if (ancestor && ancestor->hasOverflowClip())
149 m_intersectionRect.move(-rootLayoutObject->scrolledContentOffset()); 170 m_intersectionRect.move(-ancestor->scrolledContentOffset());
150
151 if (!m_doesIntersect) 171 if (!m_doesIntersect)
152 return; 172 return;
153 LayoutRect rootClipRect(m_rootRect); 173 LayoutRect rootClipRect(m_rootRect);
154 rootLayoutObject->flipForWritingMode(rootClipRect); 174 if (ancestor)
175 ancestor->flipForWritingMode(rootClipRect);
155 m_doesIntersect &= m_intersectionRect.inclusiveIntersect(rootClipRect); 176 m_doesIntersect &= m_intersectionRect.inclusiveIntersect(rootClipRect);
156 } 177 }
157 178
158 void IntersectionGeometry::mapTargetRectToTargetFrameCoordinates() { 179 void IntersectionGeometry::mapTargetRectToTargetFrameCoordinates() {
159 LayoutObject& targetLayoutObject = *m_target->layoutObject();
160 Document& targetDocument = m_target->document(); 180 Document& targetDocument = m_target->document();
161 LayoutSize scrollPosition = 181 LayoutSize scrollPosition =
162 LayoutSize(targetDocument.view()->getScrollOffset()); 182 LayoutSize(targetDocument.view()->getScrollOffset());
163 mapRectUpToDocument(m_targetRect, targetLayoutObject, targetDocument); 183 mapRectUpToDocument(m_targetRect, *m_target, targetDocument);
164 m_targetRect.move(-scrollPosition); 184 m_targetRect.move(-scrollPosition);
165 } 185 }
166 186
167 void IntersectionGeometry::mapRootRectToRootFrameCoordinates() { 187 void IntersectionGeometry::mapRootRectToRootFrameCoordinates() {
168 LayoutObject& rootLayoutObject = *getRootLayoutObject(); 188 Document& rootDocument = m_root->document();
169 Document& rootDocument = rootLayoutObject.document(); 189 if (!rootIsImplicit())
190 mapRectUpToDocument(m_rootRect, *m_root, rootDocument);
191 // TODO(szager): When OOPIF support lands, this scroll offset adjustment
192 // will probably be wrong.
170 LayoutSize scrollPosition = 193 LayoutSize scrollPosition =
171 LayoutSize(rootDocument.view()->getScrollOffset()); 194 LayoutSize(rootDocument.view()->getScrollOffset());
172 mapRectUpToDocument(m_rootRect, rootLayoutObject,
173 rootLayoutObject.document());
174 m_rootRect.move(-scrollPosition); 195 m_rootRect.move(-scrollPosition);
175 } 196 }
176 197
177 void IntersectionGeometry::mapRootRectToTargetFrameCoordinates() { 198 void IntersectionGeometry::mapIntersectionRectToTargetFrameCoordinates() {
178 LayoutObject& rootLayoutObject = *getRootLayoutObject();
179 Document& targetDocument = m_target->document(); 199 Document& targetDocument = m_target->document();
180 LayoutSize scrollPosition = 200 if (rootIsImplicit()) {
181 LayoutSize(targetDocument.view()->getScrollOffset()); 201 LocalFrame* targetFrame = targetDocument.frame();
182 202 Frame* rootFrame = targetFrame->tree().top();
183 if (&targetDocument == &rootLayoutObject.document()) { 203 LayoutSize scrollPosition =
184 mapRectUpToDocument(m_intersectionRect, rootLayoutObject, targetDocument); 204 LayoutSize(targetDocument.view()->getScrollOffset());
205 if (targetFrame != rootFrame)
206 mapRectDownToDocument(m_intersectionRect, nullptr, targetDocument);
207 m_intersectionRect.move(-scrollPosition);
185 } else { 208 } else {
186 mapRectDownToDocument(m_intersectionRect, 209 LayoutSize scrollPosition =
187 toLayoutBoxModelObject(rootLayoutObject), 210 LayoutSize(targetDocument.view()->getScrollOffset());
188 targetDocument); 211 mapRectUpToDocument(m_intersectionRect, *m_root, m_root->document());
212 m_intersectionRect.move(-scrollPosition);
189 } 213 }
190
191 m_intersectionRect.move(-scrollPosition);
192 } 214 }
193 215
194 void IntersectionGeometry::computeGeometry() { 216 void IntersectionGeometry::computeGeometry() {
195 // In the first few lines here, before initializeGeometry is called, "return 217 if (!isValid())
196 // true" effectively means "if the previous observed state was that root and
197 // target were intersecting, then generate a notification indicating that they
198 // are no longer intersecting." This happens, for example, when root or
199 // target is removed from the DOM tree and not reinserted before the next
200 // frame is generated, or display:none is set on the root or target.
201 if (!m_target->isConnected())
202 return; 218 return;
203 Element* rootElement = root();
204 if (rootElement && !rootElement->isConnected())
205 return;
206
207 LayoutObject* rootLayoutObject = getRootLayoutObject();
208 if (!rootLayoutObject || !rootLayoutObject->isBoxModelObject())
209 return;
210 // TODO(szager): Support SVG
211 LayoutObject* targetLayoutObject = m_target->layoutObject();
212 if (!targetLayoutObject)
213 return;
214 if (!targetLayoutObject->isBoxModelObject() && !targetLayoutObject->isText())
215 return;
216 if (!isContainingBlockChainDescendant(targetLayoutObject, rootLayoutObject))
217 return;
218
219 initializeGeometry();
220
221 clipToRoot(); 219 clipToRoot();
222
223 mapTargetRectToTargetFrameCoordinates(); 220 mapTargetRectToTargetFrameCoordinates();
224
225 if (m_doesIntersect) 221 if (m_doesIntersect)
226 mapRootRectToTargetFrameCoordinates(); 222 mapIntersectionRectToTargetFrameCoordinates();
227 else 223 else
228 m_intersectionRect = LayoutRect(); 224 m_intersectionRect = LayoutRect();
229
230 // Small optimization: if we're not going to report root bounds, don't bother 225 // Small optimization: if we're not going to report root bounds, don't bother
231 // transforming them to the frame. 226 // transforming them to the frame.
232 if (m_shouldReportRootBounds == ReportRootBounds::kShouldReportRootBounds) 227 if (shouldReportRootBounds())
233 mapRootRectToRootFrameCoordinates(); 228 mapRootRectToRootFrameCoordinates();
234 } 229 }
235 230
236 DEFINE_TRACE(IntersectionGeometry) {
237 visitor->trace(m_root);
238 visitor->trace(m_target);
239 }
240
241 } // namespace blink 231 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698