chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc - Issue 25531002: Move language detection to a component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

Issue 25531002: Move language detection to a component (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix compilation Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

diff --git a/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc b/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

index 85ca93467b9675664d3df666666775da9ddbf65e..3cecc6fb07a1616acc74ff3901b275df944f230d 100644

--- a/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

+++ b/chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc

@@ -14,8 +14,8 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/webui/translate_internals/translate_internals_handler.h"

#include "chrome/common/chrome_switches.h"

-#include "chrome/common/translate/language_detection_util.h"

#include "chrome/common/url_constants.h"

+#include "components/translate/language_detection/language_detection_util.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_ui.h"

#include "content/public/browser/web_ui_data_source.h"

@@ -61,7 +61,7 @@ content::WebUIDataSource* CreateTranslateInternalsHTMLSource() {

source->AddString(key, value);

}

- std::string cld_version = LanguageDetectionUtil::GetCLDVersion();

+ std::string cld_version = translate::GetCLDVersion();

blundell 2013/10/02 10:01:17 Add a TODO to replace this call via the hack that

droger 2013/10/02 10:59:41 Done.

source->AddString("cld-version", cld_version);

return source;

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/ui/startup/bad_flags_prompt.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/chrome_renderer.gypi » ('J')