Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2553093003: Create scroll properties for main thread scrolling even w/o scrolling (Closed)

Created:
4 years ago by pdr.
Modified:
4 years ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create scroll properties for main thread scrolling even w/o scrolling If an object with overflow scrolling does not actually scroll, we would not create a scroll paint property node before this patch. This was wrong because a paint property node may be needed for main thread scrolling reasons. BUG=671419 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/132d9363bf25b5f64df16d35aa8515c8ae0b9e90 Cr-Commit-Position: refs/heads/master@{#436833}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -25 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 2 chunks +30 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
pdr.
4 years ago (2016-12-06 22:00:41 UTC) #3
Xianzhu
lgtm
4 years ago (2016-12-06 22:14:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553093003/1
4 years ago (2016-12-07 01:58:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 02:06:39 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-07 02:10:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/132d9363bf25b5f64df16d35aa8515c8ae0b9e90
Cr-Commit-Position: refs/heads/master@{#436833}

Powered by Google App Engine
This is Rietveld 408576698