Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2553053002: Use ReloadMainResource for per-frame reload (Closed)

Created:
4 years ago by Takashi Toyoshima
Modified:
4 years ago
CC:
chromium-reviews, Charlie Reis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ReloadMainResource for per-frame reload Now NavigationController uses ReloadMainResource by default. Let's make other use cases aligned to make Chrome consistent. BUG=670196 Committed: https://crrev.com/7b557832fd015fb056585ed3798cc2a626fff076 Cr-Commit-Position: refs/heads/master@{#436581}

Patch Set 1 #

Patch Set 2 : rf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/renderer/content_settings_observer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Takashi Toyoshima
ptal
4 years ago (2016-12-06 12:57:44 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-06 13:09:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553053002/20001
4 years ago (2016-12-06 13:24:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 13:49:26 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-06 13:51:49 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b557832fd015fb056585ed3798cc2a626fff076
Cr-Commit-Position: refs/heads/master@{#436581}

Powered by Google App Engine
This is Rietveld 408576698