third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js - Issue 2553043003: [DevTools] Remove methods on Common.Event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)

Patch Set: rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

index 97f7c84f982da70ac3cdcbe02876d07e01cea2c4..c99bed20ca50929251404344ea51f66a0b746397 100644

--- a/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

+++ b/third_party/WebKit/Source/devtools/front_end/resources/AppManifestView.js

@@ -19,7 +19,7 @@ Resources.AppManifestView = class extends UI.VBox {

toolbar.renderAsLinks();

var addToHomeScreen =

new UI.ToolbarButton(Common.UIString('Add to homescreen'), undefined, Common.UIString('Add to homescreen'));

- addToHomeScreen.addEventListener('click', this._addToHomescreen.bind(this));

+ addToHomeScreen.addEventListener(UI.ToolbarButton.Events.Click, this._addToHomescreen, this);

toolbar.appendToolbarItem(addToHomeScreen);

this._presentationSection = this._reportView.appendSection(Common.UIString('Presentation'));

@@ -136,7 +136,10 @@ Resources.AppManifestView = class extends UI.VBox {

}

- _addToHomescreen() {

+ /**

+ * @param {!Common.Event} event

+ */

+ _addToHomescreen(event) {

var target = SDK.targetManager.mainTarget();

if (target && target.hasBrowserCapability()) {

target.pageAgent().requestAppBanner();