Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/Main.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/Main.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js b/third_party/WebKit/Source/devtools/front_end/main/Main.js
index 52c64817f9a209ee4175bee99364f07b786c9b75..8e59758ff759f9279934c5d687a658abac46fc7a 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js
@@ -674,7 +674,7 @@ Main.Main.WarningErrorCounter = class {
Main.Main.MainMenuItem = class {
constructor() {
this._item = new UI.ToolbarButton(Common.UIString('Customize and control DevTools'), 'largeicon-menu');
- this._item.addEventListener('mousedown', this._mouseDown, this);
+ this._item.addEventListener(UI.ToolbarButton.Events.MouseDown, this._mouseDown, this);
}
/**
@@ -706,9 +706,12 @@ Main.Main.MainMenuItem = class {
var undock = new UI.ToolbarToggle(Common.UIString('Undock into separate window'), 'largeicon-undock');
var bottom = new UI.ToolbarToggle(Common.UIString('Dock to bottom'), 'largeicon-dock-to-bottom');
var right = new UI.ToolbarToggle(Common.UIString('Dock to right'), 'largeicon-dock-to-right');
- undock.addEventListener('mouseup', setDockSide.bind(null, Components.DockController.State.Undocked));
- bottom.addEventListener('mouseup', setDockSide.bind(null, Components.DockController.State.DockedToBottom));
- right.addEventListener('mouseup', setDockSide.bind(null, Components.DockController.State.DockedToRight));
+ undock.addEventListener(
+ UI.ToolbarButton.Events.MouseUp, setDockSide.bind(null, Components.DockController.State.Undocked));
+ bottom.addEventListener(
+ UI.ToolbarButton.Events.MouseUp, setDockSide.bind(null, Components.DockController.State.DockedToBottom));
+ right.addEventListener(
+ UI.ToolbarButton.Events.MouseUp, setDockSide.bind(null, Components.DockController.State.DockedToRight));
undock.setToggled(Components.dockController.dockSide() === Components.DockController.State.Undocked);
bottom.setToggled(Components.dockController.dockSide() === Components.DockController.State.DockedToBottom);
right.setToggled(Components.dockController.dockSide() === Components.DockController.State.DockedToRight);

Powered by Google App Engine
This is Rietveld 408576698