third_party/WebKit/Source/devtools/front_end/components/DockController.js - Issue 2553043003: [DevTools] Remove methods on Common.Event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DockController.js

Issue 2553043003: [DevTools] Remove methods on Common.Event. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js ('K') | « third_party/WebKit/Source/devtools/front_end/common/Object.js ('k') | third_party/WebKit/Source/devtools/front_end/components/EventListenersView.js » ('j') | third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/DockController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/DockController.js b/third_party/WebKit/Source/devtools/front_end/components/DockController.js

index c4dfab209563812dc1277f4c12f32765e1dd4167..0a1eab69cddb8c77693257f7b5791c3744632424 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/DockController.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/DockController.js

@@ -40,7 +40,8 @@ Components.DockController = class extends Common.Object {

this._canDock = canDock;

this._closeButton = new UI.ToolbarButton(Common.UIString('Close'), 'largeicon-delete');

- this._closeButton.addEventListener('click', InspectorFrontendHost.closeWindow.bind(InspectorFrontendHost));

+ this._closeButton.addEventListener(

+ UI.ToolbarButton.Events.Click, InspectorFrontendHost.closeWindow.bind(InspectorFrontendHost));

if (!canDock) {

this._dockSide = Components.DockController.State.Undocked;