[DevTools] Remove methods on Common.Event.

third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

 /*
  * Copyright (C) IBM Corp. 2009  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 25 matching lines @@
 Sources.WatchExpressionsSidebarPane = class extends UI.ThrottledWidget {
   constructor() {
     super();
     this.registerRequiredCSS('components/objectValue.css');
 
     /** @type {!Array.<!Sources.WatchExpression>} */
     this._watchExpressions = [];
     this._watchExpressionsSetting = Common.settings.createLocalSetting('watchExpressions', []);
 
     this._addButton = new UI.ToolbarButton(Common.UIString('Add expression'), 'largeicon-add');
-    this._addButton.addEventListener('click', this._addButtonClicked.bind(this));
+    this._addButton.addEventListener(UI.ToolbarButton.Events.Click, this._addButtonClicked.bind(this));
     this._refreshButton = new UI.ToolbarButton(Common.UIString('Refresh'), 'largeicon-refresh');
-    this._refreshButton.addEventListener('click', this._refreshButtonClicked.bind(this));
+    this._refreshButton.addEventListener(UI.ToolbarButton.Events.Click, this._refreshButtonClicked, this);
 
     this._bodyElement = this.element.createChild('div', 'vbox watch-expressions');
     this._bodyElement.addEventListener('contextmenu', this._contextMenu.bind(this), false);
     this._expandController = new Components.ObjectPropertiesSectionExpandController();
 
     UI.context.addFlavorChangeListener(SDK.ExecutionContext, this.update, this);
     UI.context.addFlavorChangeListener(SDK.DebuggerModel.CallFrame, this.update, this);
     this._linkifier = new Components.Linkifier();
     this.update();
   }
@@ skipping 16 matching lines @@
   _saveExpressions() {
     var toSave = [];
     for (var i = 0; i < this._watchExpressions.length; i++) {
       if (this._watchExpressions[i].expression())
         toSave.push(this._watchExpressions[i].expression());
     }
 
     this._watchExpressionsSetting.set(toSave);
   }
 
-  /**
-   * @param {!Common.Event=} event
-   */
-  _addButtonClicked(event) {
-    if (event)
-      event.consume(true);
+  _addButtonClicked() {
     UI.viewManager.showView('sources.watch');
     this._createWatchExpression(null).startEditing();
   }
 
   /**
    * @param {!Common.Event} event
    */
   _refreshButtonClicked(event) {
-    event.consume();
     this.update();

[lushnikov, 2016/12/06 20:21:51]

nit: we can just inline this

[dgozman, 2016/12/06 21:36:16]

Done.

   }
 
   /**
    * @override
    * @return {!Promise.<?>}
    */
   doUpdate() {
     this._linkifier.reset();
     this._bodyElement.removeChildren();
     this._watchExpressions = [];
@@ skipping 319 matching lines @@
     InspectorFrontendHost.copyText(this._valueElement.textContent);
   }
 };
 
 Sources.WatchExpression._watchObjectGroupId = 'watch-group';
 
 /** @enum {symbol} */
 Sources.WatchExpression.Events = {
   ExpressionUpdated: Symbol('ExpressionUpdated')
 };