Don't disable debug symbols when building with sanitizers.

build/config/sanitizers/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build_overrides/build.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/clang/clang.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/toolchain/toolchain.gni")
@@ skipping 244 matching lines @@
       }
     }
   }
 }
 
 config("common_sanitizer_flags") {
   cflags = []
   cflags_cc = []
 
   # Sanitizers need line table info for stack traces. They don't need type info
-  # or variable info, so we can leave that out to speed up the build.
+  # or variable info, so we can leave that out to speed up the build, unless we
+  # are building with full debug symbols.

[Nico, 2016/12/06 14:34:12]

this should never happen:
https://cs.chromium.org/chromium/src/build/config/sanitizers/sanitizers.gni?q...

i know that things explode if you force that on in is msan or ubsan mode at
least

[mstensho (USE GERRIT), 2016/12/06 16:36:53]

I needed it today. I had to debug a use-after free bug. Kind of hard to debug
without debug symbols, right?

[Nico, 2016/12/06 16:47:44]

So I guess you disabled that assert in the other file, yes? Maybe that comment
there should say "Uncomment this locally and also uncomment -gline-tables-only
in sanitizers/BUILD.gn" instead? Keying this off is_debug seems wrong (I often
build with release+symbols, and I also sometimes do asan-builds with printf
debugging where i really just need line tables)

   if (using_sanitizer) {
     assert(is_clang, "sanitizers only supported with clang")
-    cflags += [
-      "-gline-tables-only",
+    if (!is_debug) {
+      cflags += [ "-gline-tables-only" ]
+    }
 
-      # Column info in debug data confuses Visual Studio's debugger, so don't
-      # use this by default.  However, clusterfuzz needs it for good attribution
-      # of reports to CLs, so turn it on there.
-      "-gcolumn-info",
-    ]
+    # Column info in debug data confuses Visual Studio's debugger, so don't
+    # use this by default.  However, clusterfuzz needs it for good attribution
+    # of reports to CLs, so turn it on there.
+    cflags += [ "-gcolumn-info" ]
   }
 
   # Common options for AddressSanitizer, LeakSanitizer, ThreadSanitizer,
   # MemorySanitizer and non-official CFI builds.
   if (using_sanitizer || (is_cfi && !is_official_build)) {
     if (is_posix) {
       cflags += [ "-fno-omit-frame-pointer" ]
     } else {
       cflags += [ "/Oy-" ]
     }
@@ skipping 253 matching lines @@
 # This allows to selectively disable ubsan_vptr, when needed. In particular,
 # if some third_party code is required to be compiled without rtti, which
 # is a requirement for ubsan_vptr.
 config("default_sanitizer_flags_but_ubsan_vptr") {
   configs = all_sanitizer_configs - [ ":ubsan_vptr_flags" ]
 }
 
 config("default_sanitizer_flags_but_coverage") {
   configs = all_sanitizer_configs - [ ":coverage_flags" ]
 }