Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2553033004: Remove ContextLifecycleObserver from WorkerPerformance (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from WorkerPerformance WorkerPerformance is inheriting from ContextLifecycleObserver only to implement EventTarget::getExecutionContext(). WorkerPerformance should just hold a strong member to ExecutionContext. BUG=610176 Committed: https://crrev.com/3ed589328bdfb4cdfe160bbf6e42dc6b9dd33d16 Cr-Commit-Position: refs/heads/master@{#436940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M third_party/WebKit/Source/core/timing/WorkerPerformance.h View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/timing/WorkerPerformance.cpp View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL Easy one.
4 years ago (2016-12-07 11:06:38 UTC) #2
sof
lgtm
4 years ago (2016-12-07 12:03:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553033004/1
4 years ago (2016-12-07 12:12:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 14:15:28 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 14:17:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ed589328bdfb4cdfe160bbf6e42dc6b9dd33d16
Cr-Commit-Position: refs/heads/master@{#436940}

Powered by Google App Engine
This is Rietveld 408576698