Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2553033002: [wasm] [asm.js] Avoid expensive GetLineNumber up front in asm-typer. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] [asm.js] Avoid expensive GetLineNumber up front in asm-typer. In switching to incremental parsing, we switched to pre-computing line numbers for forward declarations. This is expensive, because GetLineNumber reparses lines. Also, switch typing maps to unordered_map (as they appear hot). BUG=v8:4203 R=titzer@chromium.org Committed: https://crrev.com/52fd3c1ec5b443de7333f1b53ed25cbc754bd412 Cr-Commit-Position: refs/heads/master@{#41525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/asmjs/asm-typer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/asmjs/asm-typer.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bradnelson
4 years ago (2016-12-06 10:35:34 UTC) #1
titzer
On 2016/12/06 10:35:34, bradnelson wrote: lgtm
4 years ago (2016-12-06 10:42:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553033002/1
4 years ago (2016-12-06 14:06:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 14:07:39 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-06 14:08:00 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52fd3c1ec5b443de7333f1b53ed25cbc754bd412
Cr-Commit-Position: refs/heads/master@{#41525}

Powered by Google App Engine
This is Rietveld 408576698