Style fix in LinkStyle.cpp

third_party/WebKit/Source/core/html/LinkStyle.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/LinkStyle.h"
 
 #include "core/css/StyleSheetContents.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/SubresourceIntegrity.h"
 #include "core/frame/csp/ContentSecurityPolicy.h"
@@ skipping 218 matching lines @@
     return;
   }
 
   m_owner->document().styleEngine().removePendingSheet(*m_owner,
                                                        m_styleEngineContext);
 }
 
 void LinkStyle::setDisabledState(bool disabled) {
   LinkStyle::DisabledState oldDisabledState = m_disabledState;
   m_disabledState = disabled ? Disabled : EnabledViaScript;
-  if (oldDisabledState != m_disabledState) {
-    // If we change the disabled state while the sheet is still loading, then we
-    // have to perform three checks:
-    if (styleSheetIsLoading()) {
-      // Check #1: The sheet becomes disabled while loading.
-      if (m_disabledState == Disabled)
-        removePendingSheet();
+  if (oldDisabledState == m_disabledState)
+    return;
 
-      // Check #2: An alternate sheet becomes enabled while it is still loading.
-      if (m_owner->relAttribute().isAlternate() &&
-          m_disabledState == EnabledViaScript)
-        addPendingSheet(Blocking);
+  // If we change the disabled state while the sheet is still loading, then we
+  // have to perform three checks:
+  if (styleSheetIsLoading()) {
+    // Check #1: The sheet becomes disabled while loading.
+    if (m_disabledState == Disabled)
+      removePendingSheet();
 
-      // Check #3: A main sheet becomes enabled while it was still loading and
-      // after it was disabled via script. It takes really terrible code to make
-      // this happen (a double toggle for no reason essentially). This happens
-      // on virtualplastic.net, which manages to do about 12 enable/disables on
-      // only 3 sheets. :)
-      if (!m_owner->relAttribute().isAlternate() &&
-          m_disabledState == EnabledViaScript && oldDisabledState == Disabled)
-        addPendingSheet(Blocking);
+    // Check #2: An alternate sheet becomes enabled while it is still loading.
+    if (m_owner->relAttribute().isAlternate() &&
+        m_disabledState == EnabledViaScript)
+      addPendingSheet(Blocking);
 
-      // If the sheet is already loading just bail.
-      return;
-    }
+    // Check #3: A main sheet becomes enabled while it was still loading and
+    // after it was disabled via script. It takes really terrible code to make
+    // this happen (a double toggle for no reason essentially). This happens
+    // on virtualplastic.net, which manages to do about 12 enable/disables on
+    // only 3 sheets. :)
+    if (!m_owner->relAttribute().isAlternate() &&
+        m_disabledState == EnabledViaScript && oldDisabledState == Disabled)
+      addPendingSheet(Blocking);
 
-    if (m_sheet) {
-      m_sheet->setDisabled(disabled);
-      return;
-    }
+    // If the sheet is already loading just bail.
+    return;
+  }
 
-    if (m_disabledState == EnabledViaScript && m_owner->shouldProcessStyle())
-      process();
+  if (m_sheet) {
+    m_sheet->setDisabled(disabled);
+    return;
   }
+
+  if (m_disabledState == EnabledViaScript && m_owner->shouldProcessStyle())
+    process();
 }
 
 void LinkStyle::setCrossOriginStylesheetStatus(CSSStyleSheet* sheet) {
   if (m_fetchFollowingCORS && resource() && !resource()->errorOccurred()) {
     // Record the security origin the CORS access check succeeded at, if cross
     // origin.  Only origins that are script accessible to it may access the
     // stylesheet's rules.
     sheet->setAllowRuleAccessFromOrigin(
         m_owner->document().getSecurityOrigin());
   }
@@ skipping 116 matching lines @@
     StyleEngine::ActiveSheetsUpdate updateActiveSheets) {
   if (!m_owner->isInDocumentTree() || !m_owner->relAttribute().isStyleSheet())
     return;
 
   if (m_sheet)
     m_sheet->setTitle(title);
 
   if (title.isEmpty() || !isUnset() || m_owner->isAlternate())
     return;
 
-  KURL href = m_owner->getNonEmptyURLAttribute(hrefAttr);
+  const KURL& href = m_owner->getNonEmptyURLAttribute(hrefAttr);
   if (href.isValid() && !href.isEmpty()) {
     document().styleEngine().setPreferredStylesheetSetNameIfNotSet(
         title, updateActiveSheets);
   }
 }
 
 void LinkStyle::ownerRemoved() {
   if (m_sheet)
     clearSheet();
 
   if (styleSheetIsLoading())
     removePendingSheet();
 }
 
 DEFINE_TRACE(LinkStyle) {
   visitor->trace(m_sheet);
   LinkResource::trace(visitor);
   ResourceOwner<StyleSheetResource>::trace(visitor);
 }
 
 }  // namespace blink