Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7281)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java

Issue 2553013004: Remove the app banner navigation heuristic. (Closed)
Patch Set: Add comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/test/data/banners/prompt_in_handler_test_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java
index f14c28e83acfd400741ac6fc6dc6aa57eaea60e4..11efcc2177c8669bf280874fa05271295fcf9f09 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/TabLoadObserver.java
@@ -15,6 +15,7 @@ import org.chromium.chrome.browser.tab.Tab;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
import org.chromium.content_public.browser.LoadUrlParams;
+import org.chromium.ui.base.PageTransition;
import java.util.Locale;
@@ -63,10 +64,20 @@ public class TabLoadObserver extends EmptyTabObserver {
* @param url URL to load and wait for.
*/
public void fullyLoadUrl(final String url) throws Exception {
+ fullyLoadUrl(url, PageTransition.LINK);
+ }
+
+ /**
+ * Loads the given URL and waits for it to complete.
+ *
+ * @param url URL to load and wait for.
+ * @param transitionType the transition type to use.
+ */
+ public void fullyLoadUrl(final String url, final int transitionType) throws Exception {
ThreadUtils.runOnUiThread(new Runnable() {
@Override
public void run() {
- mTab.loadUrl(new LoadUrlParams(url));
+ mTab.loadUrl(new LoadUrlParams(url, transitionType));
}
});
assertLoaded();
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/test/data/banners/prompt_in_handler_test_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698