| Index: chrome/browser/banners/app_banner_settings_helper.h
|
| diff --git a/chrome/browser/banners/app_banner_settings_helper.h b/chrome/browser/banners/app_banner_settings_helper.h
|
| index 06ab2f30d02e3ee1198168884a4a20e76cb4c537..2af2ed31d283cd85fce3e5582e2aca7ece00e587 100644
|
| --- a/chrome/browser/banners/app_banner_settings_helper.h
|
| +++ b/chrome/browser/banners/app_banner_settings_helper.h
|
| @@ -7,12 +7,10 @@
|
|
|
| #include <set>
|
| #include <string>
|
| -#include <vector>
|
|
|
| #include "base/macros.h"
|
| #include "base/time/time.h"
|
| #include "chrome/browser/installable/installable_logging.h"
|
| -#include "ui/base/page_transition_types.h"
|
|
|
| namespace content {
|
| class WebContents;
|
| @@ -69,13 +67,6 @@ class AppBannerSettingsHelper {
|
|
|
| static const char kInstantAppsKey[];
|
|
|
| - // BannerEvents record the time that a site was accessed, along with an
|
| - // engagement weight representing the importance of the access.
|
| - struct BannerEvent {
|
| - base::Time time;
|
| - double engagement;
|
| - };
|
| -
|
| // The content setting basically records a simplified subset of history.
|
| // For privacy reasons this needs to be cleared. The ClearHistoryForURLs
|
| // function removes any information from the banner content settings for the
|
| @@ -95,22 +86,13 @@ class AppBannerSettingsHelper {
|
| const std::string& package_name_or_start_url,
|
| AppBannerRapporMetric rappor_metric);
|
|
|
| - // Record a banner event. Should not be used for could show events, as they
|
| - // require a transition type.
|
| + // Record a banner event specified by |event|.
|
| static void RecordBannerEvent(content::WebContents* web_contents,
|
| const GURL& origin_url,
|
| const std::string& package_name_or_start_url,
|
| AppBannerEvent event,
|
| base::Time time);
|
|
|
| - // Record a banner could show event, with a specified transition type.
|
| - static void RecordBannerCouldShowEvent(
|
| - content::WebContents* web_contents,
|
| - const GURL& origin_url,
|
| - const std::string& package_name_or_start_url,
|
| - base::Time time,
|
| - ui::PageTransition transition_type);
|
| -
|
| // Determine if the banner should be shown, given the recorded events for the
|
| // supplied app. Returns an InstallableStatusCode indicated the reason why the
|
| // banner shouldn't be shown, or NO_ERROR_DETECTED if it should be shown.
|
| @@ -120,16 +102,8 @@ class AppBannerSettingsHelper {
|
| const std::string& package_name_or_start_url,
|
| base::Time time);
|
|
|
| - // Gets the could have been shown events that are stored for the given package
|
| - // or start url. This is only exposed for testing.
|
| - static std::vector<BannerEvent> GetCouldShowBannerEvents(
|
| - content::WebContents* web_contents,
|
| - const GURL& origin_url,
|
| - const std::string& package_name_or_start_url);
|
| -
|
| - // Get the recorded event for an event type that only records the last event.
|
| - // Should not be used with APP_BANNER_EVENT_COULD_SHOW. This is only exposed
|
| - // for testing.
|
| + // Get the time that |event| was recorded, or a null time if it has not yet
|
| + // been recorded. Exposed for testing.
|
| static base::Time GetSingleBannerEvent(
|
| content::WebContents* web_contents,
|
| const GURL& origin_url,
|
| @@ -162,16 +136,6 @@ class AppBannerSettingsHelper {
|
| static void SetDaysAfterDismissAndIgnoreToTrigger(unsigned int dismiss_days,
|
| unsigned int ignore_days);
|
|
|
| - // Set the engagement weights assigned to direct and indirect navigations.
|
| - static void SetEngagementWeights(double direct_engagement,
|
| - double indirect_engagement);
|
| -
|
| - // Set the minimum number of minutes between banner visits that will
|
| - // trigger a could show banner event. This must be less than the
|
| - // number of minutes in a day, and evenly divide the number of minutes
|
| - // in a day.
|
| - static void SetMinimumMinutesBetweenVisits(unsigned int minutes);
|
| -
|
| // Set the total engagement weight required to trigger a banner.
|
| static void SetTotalEngagementToTrigger(double total_engagement);
|
|
|
| @@ -179,10 +143,6 @@ class AppBannerSettingsHelper {
|
| // trigger to their default values.
|
| static void SetDefaultParameters();
|
|
|
| - // Bucket a given time to the given resolution in local time.
|
| - static base::Time BucketTimeToResolution(base::Time time,
|
| - unsigned int minutes);
|
| -
|
| // Updates all values from field trial.
|
| static void UpdateFromFieldTrial();
|
|
|
| @@ -190,10 +150,6 @@ class AppBannerSettingsHelper {
|
| // app banners and add to homescreen.
|
| static LanguageOption GetHomescreenLanguageOption();
|
|
|
| - // Returns true if the app banner trigger condition should use the site
|
| - // engagement score instead of the navigation-based heuristic.
|
| - static bool ShouldUseSiteEngagementScore();
|
| -
|
| private:
|
| DISALLOW_IMPLICIT_CONSTRUCTORS(AppBannerSettingsHelper);
|
| };
|
|
|