Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 2553013004: Remove the app banner navigation heuristic. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index 781d36f7056563f2effe3470f17adb7195d230c5..8aa2d7b91181d97315d960aae1ce56b99047c23f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -157,22 +157,28 @@ public class AppBannerManager {
sIsSupported = state;
}
- /** Sets a constant (in days) that gets added to the time when the current time is requested. */
+ /** Returns whether the native AppBannerManager is working. */
@VisibleForTesting
- static void setTimeDeltaForTesting(int days) {
- nativeSetTimeDeltaForTesting(days);
+ public boolean isActiveForTesting() {
+ return nativeIsActiveForTesting(mNativePointer);
}
- /** Sets the weights of direct and indirect page navigations for testing. */
+ /** Sets constants (in days) the banner should be blocked for after dismissing and ignoring. */
@VisibleForTesting
- static void setEngagementWeights(double directEngagement, double indirectEngagement) {
- nativeSetEngagementWeights(directEngagement, indirectEngagement);
+ static void setDaysAfterDismissAndIgnoreForTesting(int dismissDays, int ignoreDays) {
+ nativeSetDaysAfterDismissAndIgnoreToTrigger(dismissDays, ignoreDays);
}
- /** Returns whether the native AppBannerManager is working. */
+ /** Sets a constant (in days) that gets added to the time when the current time is requested. */
@VisibleForTesting
- public boolean isActiveForTesting() {
- return nativeIsActiveForTesting(mNativePointer);
+ static void setTimeDeltaForTesting(int days) {
+ nativeSetTimeDeltaForTesting(days);
+ }
+
+ /** Sets the total required engagement to trigger the banner. */
+ @VisibleForTesting
+ static void setTotalEngagementForTesting(double engagement) {
+ nativeSetTotalEngagementToTrigger(engagement);
}
/** Returns the AppBannerManager object. This is owned by the C++ banner manager. */
@@ -187,8 +193,9 @@ public class AppBannerManager {
AppData data, String title, String packageName, String imageUrl);
// Testing methods.
- private static native void nativeSetTimeDeltaForTesting(int days);
- private static native void nativeSetEngagementWeights(double directEngagement,
- double indirectEngagement);
private native boolean nativeIsActiveForTesting(long nativeAppBannerManagerAndroid);
+ private static native void nativeSetDaysAfterDismissAndIgnoreToTrigger(
+ int dismissDays, int ignoreDays);
+ private static native void nativeSetTimeDeltaForTesting(int days);
+ private static native void nativeSetTotalEngagementToTrigger(double engagement);
}

Powered by Google App Engine
This is Rietveld 408576698