Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2552963002: DevTools: do not include unit_test_runner in resources.pak (Closed)

Created:
4 years ago by chenwilliam
Modified:
4 years ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not include unit_test_runner in resources.pak My previous CL inadvertently caused a file size regression because unit_test_runner.js (~1.2MB) was being included in resources.pak. This excludes unit_test_runner.js/html from being included in the devtools_resources.grd and subsequently the resources.pak. CL which caused file size regression: https://codereview.chromium.org/2513423003 BUG=670734 Committed: https://crrev.com/8a3318ab2d4685e1edd8bfcda51f1d5d5c8d3e49 Cr-Commit-Position: refs/heads/master@{#436508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
chenwilliam
PTAL. This fixes a P1 issue that I caused.
4 years ago (2016-12-06 01:18:31 UTC) #2
dgozman
lgtm
4 years ago (2016-12-06 01:29:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552963002/1
4 years ago (2016-12-06 01:33:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 03:20:19 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-06 03:22:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a3318ab2d4685e1edd8bfcda51f1d5d5c8d3e49
Cr-Commit-Position: refs/heads/master@{#436508}

Powered by Google App Engine
This is Rietveld 408576698