Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1507)

Issue 2552953002: Floating legend should be added to the fieldset's anonymous block. (Closed)

Created:
4 years ago by Gleb Lanbin
Modified:
4 years ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Floating legend should be added to the fieldset's anonymous block. If fieldset's legend is floating it should be added to the existing fieldset\'s anonymous block instead of creating a nested one. This is necessary because flexbox forces the floating legend to be non-floating and therefore if the legend needs to be floating it should be added to the fieldset's anonymous block. BUG=661230, 670837 TEST=fast/forms/fieldset/fieldset-legend-float.html NOTRY=true NOPRESUBMIT=true Tested with real world websites: https://jsbin.com/zutekilusi/1/edit?html,css,output http://www.timico.co.uk/timico-ltd-application-form http://codepen.io/michaelpumo/pen/VmZqrr https://en.wikipedia.org/wiki/Special:ActiveUsers https://jsfiddle.net/tdbthtra/ Review-Url: https://codereview.chromium.org/2550963002 Cr-Commit-Position: refs/heads/master@{#436187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
A third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float.html View 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-legend-float-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 2 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
ikilpatrick
lgtm
4 years ago (2016-12-06 01:02:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552953002/1
4 years ago (2016-12-06 01:04:07 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-06 01:10:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698