Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 255293002: Rename UpdateRendererStateForNavigate (Closed)

Created:
6 years, 7 months ago by nasko
Modified:
6 years, 7 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Rename UpdateRendererStateForNavigate The method name is a bit confusing, as it isn't updating any renderer. It makes a policy decision which RenderFrameHost should handle the navigation and returns it out. Dropping the "Renderer" part of the name makes it a bit better. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267128

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix line wrap. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M content/browser/frame_host/render_frame_host_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/cross_site_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
nasko
Hey Charlie, As we discussed earlier, the name of UpdateRendererStateForNavigate can be better. This is ...
6 years, 7 months ago (2014-04-29 21:21:37 UTC) #1
Charlie Reis
Thanks, LGTM. https://codereview.chromium.org/255293002/diff/1/content/browser/frame_host/render_frame_host_manager.cc File content/browser/frame_host/render_frame_host_manager.cc (right): https://codereview.chromium.org/255293002/diff/1/content/browser/frame_host/render_frame_host_manager.cc#newcode168 content/browser/frame_host/render_frame_host_manager.cc:168: UpdateStateForNavigate(entry); This can fit on the previous ...
6 years, 7 months ago (2014-04-29 21:32:08 UTC) #2
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 7 months ago (2014-04-29 21:33:59 UTC) #3
nasko
Done. https://codereview.chromium.org/255293002/diff/1/content/browser/frame_host/render_frame_host_manager.cc File content/browser/frame_host/render_frame_host_manager.cc (right): https://codereview.chromium.org/255293002/diff/1/content/browser/frame_host/render_frame_host_manager.cc#newcode168 content/browser/frame_host/render_frame_host_manager.cc:168: UpdateStateForNavigate(entry); On 2014/04/29 21:32:09, Charlie Reis wrote: > ...
6 years, 7 months ago (2014-04-29 21:34:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/255293002/20001
6 years, 7 months ago (2014-04-29 21:36:04 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:12:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:12:11 UTC) #7
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 7 months ago (2014-04-29 22:12:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/255293002/20001
6 years, 7 months ago (2014-04-29 22:16:34 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 02:03:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 02:03:18 UTC) #11
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 7 months ago (2014-04-30 05:15:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/255293002/20001
6 years, 7 months ago (2014-04-30 05:15:50 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 08:00:03 UTC) #14
Message was sent while issue was closed.
Change committed as 267128

Powered by Google App Engine
This is Rietveld 408576698