Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2552913004: [wasm][asm.js] Require exported asm.js functions have be names. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Require exported asm.js functions have be names. The asm.js spec requires exports to be identifiers, this was DCHECKED in the asm-wasm-builder, but not the typer. BUG=672046 R=titzer@chromium.org Committed: https://crrev.com/582cdddeb4fa03fb2cc807769aa5fbc1927db83b Cr-Commit-Position: refs/heads/master@{#41557}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/asmjs/asm-typer.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
bradn
4 years ago (2016-12-07 15:21:13 UTC) #6
titzer
lgtm
4 years ago (2016-12-07 15:27:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552913004/20001
4 years ago (2016-12-07 15:34:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 15:55:29 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-07 15:55:55 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/582cdddeb4fa03fb2cc807769aa5fbc1927db83b
Cr-Commit-Position: refs/heads/master@{#41557}

Powered by Google App Engine
This is Rietveld 408576698