Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2552913003: Revert of Replacing allocate bitmap IPC messages with a new Mojo interface. (Closed)

Created:
4 years ago by Jay Civelli
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replacing allocate bitmap IPC messages with a new Mojo interface. (patchset #13 id:240001 of https://codereview.chromium.org/2488913003/ ) Reason for revert: Might be causing a crasher on Windows. http://crbug.com/671459 Original issue's description: > Replacing the AllocateBitmap related IPC messages with new mojo methods in the > RenderMessageFilter interface (it has to be part of the associated interface for > now because of ordering issue with other CC messages). > > As part of that, unified the bitmap allocation behavior in > ChildSharedBitmapManager on all platforms, by allocating shared memory > with the generic shared memory allocation code path and then > registering it as a bitmap. > Also moved ChildSharedBitmapManager from the ChildThreadImpl to RenderThreadImpl > as it is not common to all child processes. > > BUG=612500 > TEST=content_shell should run normally with the --dissable-gpu flag. > > Committed: https://crrev.com/97235f8be07b5fe9200fe76901d27833325a5996 > Cr-Commit-Position: refs/heads/master@{#436095} TBR=rockot@chromium.org,jbauman@chromium.org,kinuko@chromium.org,tsepez@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=612500 Committed: https://crrev.com/9a8e7d0071e6e2492a9f997c22238596ab4122dd Cr-Commit-Position: refs/heads/master@{#436629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -124 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 2 chunks +13 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 5 chunks +40 lines, -12 lines 0 comments Download
M content/child/child_shared_bitmap_manager.h View 3 chunks +5 lines, -10 lines 0 comments Download
M content/child/child_shared_bitmap_manager.cc View 6 chunks +56 lines, -54 lines 0 comments Download
M content/child/child_thread_impl.h View 3 chunks +7 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/child_process_messages.h View 1 chunk +17 lines, -0 lines 0 comments Download
M content/common/render_message_filter.mojom View 2 chunks +0 lines, -12 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/pepper/pepper_compositor_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 3 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jay Civelli
Created Revert of Replacing allocate bitmap IPC messages with a new Mojo interface.
4 years ago (2016-12-06 16:44:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552913003/1
4 years ago (2016-12-06 16:45:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 17:44:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9a8e7d0071e6e2492a9f997c22238596ab4122dd Cr-Commit-Position: refs/heads/master@{#436629}
4 years ago (2016-12-06 17:46:58 UTC) #8
Jay Civelli
4 years ago (2016-12-07 19:35:27 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2549213005/ by jcivelli@chromium.org.

The reason for reverting is: The revert did not help with the crasher, so
relanding this CL..

Powered by Google App Engine
This is Rietveld 408576698