Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2552913002:
Add tests for highlighting, editing and updating CSS styles for UI DevTools (Closed)
|
Created:
4 years ago by Sarmad Hashmi Modified:
4 years ago Reviewers:
sadrul CC:
chromium-reviews, kalyank, sadrul, pfeldman, devtools-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd tests for highlighting, editing and updating CSS styles for UI DevTools
This CL adds test coverage for the following:
- Tests for highlighting window, widget, view on single/multiple display
- Tests for editing CSS styles (bounds for now) from the frontend
- When bounds get updated, the frontend should be notified of updates.
This is also tested.
BUG=648701
Committed: https://crrev.com/b1a6e98d9bcf2b49555dc0056e3e7ca40eabbd80
Cr-Commit-Position: refs/heads/master@{#437077}
Patch Set 1 #Patch Set 2 : Add tests for highlighting, editing and updating CSS styles for UI DevTools #Patch Set 3 : Add tests for highlighting, editing and updating CSS styles for UI DevTools #
Total comments: 7
Patch Set 4 : sadruls comments #Patch Set 5 : rebase #Messages
Total messages: 27 (21 generated)
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
mhashmi@chromium.org changed reviewers: + sadrul@chromium.org
Ttests for the 1 feature landed and 2 in review all combined.
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm! https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... File ash/common/devtools/ash_devtools_unittest.cc (right): https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... ash/common/devtools/ash_devtools_unittest.cc:6: #include "ash/common/devtools/ash_devtools_dom_agent.h" I think you can move all #includes in the same block now. https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... ash/common/devtools/ash_devtools_unittest.cc:23: const SkColor background_color = SK_ColorRED; kBackgroundColor kBorderColor https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... ash/common/devtools/ash_devtools_unittest.cc:614: HideHighlight(0); What does higlighting 'node 0' mean? https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... ash/common/devtools/ash_devtools_unittest.cc:651: ExpectHighlighted(window->GetBoundsInScreen(), 1); Cool!
https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... File ash/common/devtools/ash_devtools_unittest.cc (right): https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... ash/common/devtools/ash_devtools_unittest.cc:6: #include "ash/common/devtools/ash_devtools_dom_agent.h" On 2016/12/07 17:47:57, sadrul wrote: > I think you can move all #includes in the same block now. Done. https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... ash/common/devtools/ash_devtools_unittest.cc:23: const SkColor background_color = SK_ColorRED; On 2016/12/07 17:47:57, sadrul wrote: > kBackgroundColor > kBorderColor Done. https://codereview.chromium.org/2552913002/diff/40001/ash/common/devtools/ash... ash/common/devtools/ash_devtools_unittest.cc:614: HideHighlight(0); On 2016/12/07 17:47:57, sadrul wrote: > What does higlighting 'node 0' mean? It hides the highlight on display 0 (aka primary display).
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mhashmi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mhashmi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org Link to the patchset: https://codereview.chromium.org/2552913002/#ps80001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481147596340330,
"parent_rev": "1965de252f0428b2250a85202dc1791de0e4661e", "commit_rev":
"7df6ca470f5ef6d95c3c7e2343d81121e3e6045e"}
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Add tests for highlighting, editing and updating CSS styles for UI DevTools This CL adds test coverage for the following: - Tests for highlighting window, widget, view on single/multiple display - Tests for editing CSS styles (bounds for now) from the frontend - When bounds get updated, the frontend should be notified of updates. This is also tested. BUG=648701 ========== to ========== Add tests for highlighting, editing and updating CSS styles for UI DevTools This CL adds test coverage for the following: - Tests for highlighting window, widget, view on single/multiple display - Tests for editing CSS styles (bounds for now) from the frontend - When bounds get updated, the frontend should be notified of updates. This is also tested. BUG=648701 Committed: https://crrev.com/b1a6e98d9bcf2b49555dc0056e3e7ca40eabbd80 Cr-Commit-Position: refs/heads/master@{#437077} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/b1a6e98d9bcf2b49555dc0056e3e7ca40eabbd80 Cr-Commit-Position: refs/heads/master@{#437077} |
