Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2679)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2552903003: Remove unreleased web app frame code from ChromeOS (Closed)
Patch Set: Nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index f2a776f3b188e2ffb5e54ed5588256b86d3b0d6b..e34983dae09a4faf5753142b2ef8d19836919241 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1035,7 +1035,6 @@ void BrowserView::UpdateToolbar(content::WebContents* contents) {
// We may end up here during destruction.
if (toolbar_)
toolbar_->Update(contents);
- frame_->UpdateToolbar();
}
void BrowserView::ResetToolbarTabState(content::WebContents* contents) {
@@ -1283,14 +1282,10 @@ void BrowserView::ShowWebsiteSettings(
content::WebContents* web_contents,
const GURL& virtual_url,
const security_state::SecurityInfo& security_info) {
- // Some browser windows have a location icon embedded in the frame. Try to
- // use that if it exists. If it doesn't exist, use the location icon from
- // the location bar.
- views::View* popup_anchor =
- ui::MaterialDesignController::IsSecondaryUiMaterial()
- ? toolbar_->location_bar()
- : frame_->GetLocationIconView();
- if (!popup_anchor)
+ views::View* popup_anchor = nullptr;
+ if (ui::MaterialDesignController::IsSecondaryUiMaterial())
+ popup_anchor = toolbar_->location_bar();
+ else
popup_anchor = GetLocationBarView()->location_icon_view()->GetImageView();
WebsiteSettingsPopupView::ShowPopup(popup_anchor, gfx::Rect(), profile,
@@ -1611,8 +1606,7 @@ bool BrowserView::ShouldShowWindowTitle() const {
#if defined(USE_ASH)
// For Ash only, trusted windows (apps and settings) do not show a title,
// crbug.com/119411. Child windows (i.e. popups) do show a title.
- if (browser_->is_trusted_source() &&
- !browser_->SupportsWindowFeature(Browser::FEATURE_WEBAPPFRAME))
+ if (browser_->is_trusted_source())
return false;
#endif // USE_ASH
@@ -1646,8 +1640,7 @@ bool BrowserView::ShouldShowWindowIcon() const {
#if defined(USE_ASH)
// For Ash only, trusted windows (apps and settings) do not show an icon,
// crbug.com/119411. Child windows (i.e. popups) do show an icon.
- if (browser_->is_trusted_source() &&
- !browser_->SupportsWindowFeature(Browser::FEATURE_WEBAPPFRAME))
+ if (browser_->is_trusted_source())
return false;
#endif // USE_ASH

Powered by Google App Engine
This is Rietveld 408576698