Move pure functions in CSSComputedStyleDeclaration.cpp into their own private namespace.

Move pure functions in CSSComputedStyleDeclaration.cpp into their own private namespace.

This prevents naming conflicts in the blink namespace, which could have
unexpected results.

Committed: https://crrev.com/714706d0823bdd021e8fd68221f635dd2ab8264b
Cr-Commit-Position: refs/heads/master@{#437394}

[meade_UTC10, 2016-12-08 05:35:22]

meade@chromium.org changed reviewers:
+ sashab@chromium.org

[meade_UTC10, 2016-12-08 05:35:23]

Hey Sasha! I noticed this when reviewing a CL. Do you think it's a good idea?

[meade_UTC10, 2016-12-08 05:35:42]

The CQ bit was checked by meade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 05:35:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2016-12-08 05:36:45]

Haha sure! Putting the static keyword in front of a method is equivalent to
putting them in a private namespace, but private namespaces are more C++-y.

Remove the static keyword from in front of the methods you moved because you
shouldn't have both. Other than that lgtm :)

[meade_UTC10, 2016-12-08 06:00:16]

Patchset #2 (id:20001) has been deleted

[meade_UTC10, 2016-12-08 06:03:54]

On 2016/12/08 05:36:45, sashab wrote:
> Haha sure! Putting the static keyword in front of a method is equivalent to
> putting them in a private namespace, but private namespaces are more C++-y.
> 
> Remove the static keyword from in front of the methods you moved because you
> shouldn't have both. Other than that lgtm :)

Ah yep. It's def better to use the private namespace since you definitely can't
get naming conflicts that way (although you'd know since it'd be a compile
error).

Thanks!

[meade_UTC10, 2016-12-08 06:03:58]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-12-08 06:03:58]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2552893006/#ps40001
(title: "Remove extra static keywords")

[commit-bot: I haz the power, 2016-12-08 06:04:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 07:29:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 07:29:47]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[meade_UTC10, 2016-12-08 22:28:11]

The CQ bit was checked by meade@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:29:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 23:17:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481236091111310,
"parent_rev": "5e353c0e9add38bd3aa1d99b3d598e66bbfcbcce", "commit_rev":
"a2fcd483f9fe76354b377c032c531086c6805f7f"}

[commit-bot: I haz the power, 2016-12-08 23:18:16]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-08 23:19:52]

Description was changed from

==========
Move pure functions in CSSComputedStyleDeclaration.cpp into their own private
namespace.

This prevents naming conflicts in the blink namespace, which could have
unexpected results.
==========

to

==========
Move pure functions in CSSComputedStyleDeclaration.cpp into their own private
namespace.

This prevents naming conflicts in the blink namespace, which could have
unexpected results.

Committed: https://crrev.com/714706d0823bdd021e8fd68221f635dd2ab8264b
Cr-Commit-Position: refs/heads/master@{#437394}
==========

[commit-bot: I haz the power, 2016-12-08 23:19:53]

Patchset 2 (id:??) landed as
https://crrev.com/714706d0823bdd021e8fd68221f635dd2ab8264b
Cr-Commit-Position: refs/heads/master@{#437394}