 Chromium Code Reviews
 Chromium Code Reviews Issue 2552883014:
  DevTools: fix exception in anchor icon decoration  (Closed)
    
  
    Issue 2552883014:
  DevTools: fix exception in anchor icon decoration  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * Copyright (C) 2012 Google Inc. All rights reserved. | 2 * Copyright (C) 2012 Google Inc. All rights reserved. | 
| 3 * | 3 * | 
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without | 
| 5 * modification, are permitted provided that the following conditions are | 5 * modification, are permitted provided that the following conditions are | 
| 6 * met: | 6 * met: | 
| 7 * | 7 * | 
| 8 * * Redistributions of source code must retain the above copyright | 8 * * Redistributions of source code must retain the above copyright | 
| 9 * notice, this list of conditions and the following disclaimer. | 9 * notice, this list of conditions and the following disclaimer. | 
| 10 * * Redistributions in binary form must reproduce the above | 10 * * Redistributions in binary form must reproduce the above | 
| (...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 319 | 319 | 
| 320 /** | 320 /** | 
| 321 * @param {!Element} anchor | 321 * @param {!Element} anchor | 
| 322 */ | 322 */ | 
| 323 static _updateLinkDecorations(anchor) { | 323 static _updateLinkDecorations(anchor) { | 
| 324 var info = Components.Linkifier._linkInfo(anchor); | 324 var info = Components.Linkifier._linkInfo(anchor); | 
| 325 if (!info || !info.enableDecorator) | 325 if (!info || !info.enableDecorator) | 
| 326 return; | 326 return; | 
| 327 if (!Components.Linkifier._decorator || !info.uiLocation) | 327 if (!Components.Linkifier._decorator || !info.uiLocation) | 
| 328 return; | 328 return; | 
| 329 if (info.icon) | 329 if (info.icon && info.icon.parentElement) | 
| 
dgozman
2016/12/09 21:41:48
=== anchor ?
 
lushnikov
2016/12/10 00:58:45
I'd keep this as-is; icon should always be either
 | |
| 330 anchor.removeChild(info.icon); | 330 anchor.removeChild(info.icon); | 
| 331 var icon = Components.Linkifier._decorator.linkIcon(info.uiLocation.uiSource Code); | 331 var icon = Components.Linkifier._decorator.linkIcon(info.uiLocation.uiSource Code); | 
| 332 if (icon) { | 332 if (icon) { | 
| 333 icon.style.setProperty('margin-right', '2px'); | 333 icon.style.setProperty('margin-right', '2px'); | 
| 334 anchor.insertBefore(icon, anchor.firstChild); | 334 anchor.insertBefore(icon, anchor.firstChild); | 
| 335 } | 335 } | 
| 336 info.icon = icon; | 336 info.icon = icon; | 
| 337 } | 337 } | 
| 338 | 338 | 
| 339 /** | 339 /** | 
| (...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 771 contextMenu.appendSeparator(); | 771 contextMenu.appendSeparator(); | 
| 772 contextMenu.appendItem(Common.UIString('Save'), save.bind(null, false)); | 772 contextMenu.appendItem(Common.UIString('Save'), save.bind(null, false)); | 
| 773 | 773 | 
| 774 if (contentProvider instanceof Workspace.UISourceCode) { | 774 if (contentProvider instanceof Workspace.UISourceCode) { | 
| 775 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (contentProvider ); | 775 var uiSourceCode = /** @type {!Workspace.UISourceCode} */ (contentProvider ); | 
| 776 if (!uiSourceCode.project().canSetFileContent()) | 776 if (!uiSourceCode.project().canSetFileContent()) | 
| 777 contextMenu.appendItem(Common.UIString.capitalize('Save ^as...'), save.b ind(null, true)); | 777 contextMenu.appendItem(Common.UIString.capitalize('Save ^as...'), save.b ind(null, true)); | 
| 778 } | 778 } | 
| 779 } | 779 } | 
| 780 }; | 780 }; | 
| OLD | NEW |