src/builtins/builtins-regexp.cc - Issue 2552883012: [interpreter][stubs] Fixing issues found by machine graph verifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-regexp.cc

Issue 2552883012: [interpreter][stubs] Fixing issues found by machine graph verifier. (Closed)

Patch Set: Addressing nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-regexp.cc

diff --git a/src/builtins/builtins-regexp.cc b/src/builtins/builtins-regexp.cc

index 6196f6d93a3139a8dab5164a0750aa8ed0fddc74..937efe5dfd594c27d96a422def5d81e7b948bc7a 100644

--- a/src/builtins/builtins-regexp.cc

+++ b/src/builtins/builtins-regexp.cc

@@ -258,7 +258,7 @@ Node* RegExpBuiltinsAssembler::RegExpPrototypeExecBodyWithoutResult(

// Omit ToLength if lastindex is a non-negative smi.

{

Label call_tolength(this, Label::kDeferred), next(this);

- Branch(WordIsPositiveSmi(regexp_lastindex), &next, &call_tolength);

+ Branch(TaggedIsPositiveSmi(regexp_lastindex), &next, &call_tolength);

Bind(&call_tolength);

{

« no previous file with comments | « src/builtins/builtins-conversion.cc ('k') | src/code-stub-assembler.h » ('j') | no next file with comments »