Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2552883009: [MD settings] include source of policy for content settings (Closed)

Created:
4 years ago by dschuyler
Modified:
4 years ago
Reviewers:
tommycli, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org, Dan Beam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] include source of policy for content settings This CL is a step toward showing policy (controlled by) indicators in the content settings. This CL adds the C++ side and proxy layer changes. The UI changes will be in a separate CL. This CL is a breakout piece from the lager prior CL 2509163004. BUG=662596 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d Cr-Commit-Position: refs/heads/master@{#437103}

Patch Set 1 #

Patch Set 2 : account for unset source #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
M chrome/browser/resources/settings/site_settings/site_settings_category.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js View 1 3 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc View 1 5 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/site_settings_helper.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/site_settings_helper.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/site_settings_category_tests.js View 5 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
dschuyler
This CL separates out the C++ layer of https://codereview.chromium.org/2509163004/ I believe this part of the ...
4 years ago (2016-12-07 20:31:18 UTC) #5
Dan Beam
lgtm
4 years ago (2016-12-07 21:25:05 UTC) #9
tommycli
On 2016/12/07 21:25:05, Dan Beam wrote: > lgtm rs lgtm if dan is fine with ...
4 years ago (2016-12-07 21:26:08 UTC) #10
dschuyler
Change to unit test to account for 'source' not being set when the value is ...
4 years ago (2016-12-07 22:38:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552883009/20001
4 years ago (2016-12-07 23:03:56 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 23:10:04 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-07 23:11:50 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2e359aa4089b7123cce6263658a35ac66eaa45d
Cr-Commit-Position: refs/heads/master@{#437103}

Powered by Google App Engine
This is Rietveld 408576698