Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2552883004: Deprecate WebThread::getWebTaskRunner. (Closed)

Created:
4 years ago by altimin
Modified:
4 years ago
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-api_chromium.org, alex clarke (OOO till 29th), Sami
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate WebThread::getWebTaskRunner. WebThread::getWebTaskRunner exposes default scheduler task queue, which prevents tasks from being throttled. TaskRunnerHelper should be used instead. R=haraken@chromium.org CC=alexclarke@chromium.org,skyostil@chromium.org BUG=624696 Committed: https://crrev.com/a806c8be80ff03b129f21c3315afa91a8c456206 Cr-Commit-Position: refs/heads/master@{#436600}

Patch Set 1 #

Patch Set 2 : Deprecate WebThread::getWebTaskRunner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/public/platform/WebThread.h View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
altimin
PTAL
4 years ago (2016-12-06 12:07:23 UTC) #1
alex clarke (OOO till 29th)
Can you please add a comment in the CL description explaining why we want to ...
4 years ago (2016-12-06 12:18:43 UTC) #3
altimin
On 2016/12/06 12:18:43, alex clarke wrote: > Can you please add a comment in the ...
4 years ago (2016-12-06 12:25:09 UTC) #5
alex clarke (OOO till 29th)
Non owner LGTM.
4 years ago (2016-12-06 12:27:41 UTC) #6
haraken
LGTM
4 years ago (2016-12-06 13:33:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552883004/20001
4 years ago (2016-12-06 13:37:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 15:24:53 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-06 15:26:30 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a806c8be80ff03b129f21c3315afa91a8c456206
Cr-Commit-Position: refs/heads/master@{#436600}

Powered by Google App Engine
This is Rietveld 408576698