Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: src/asmjs/asm-wasm-builder.cc

Issue 2552873003: [wasm][asm.js] Pass Script with Handle. (Closed)
Patch Set: re-enable tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/asmjs/asm-wasm-builder.h ('k') | test/cctest/asmjs/test-asm-typer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/asmjs/asm-wasm-builder.cc
diff --git a/src/asmjs/asm-wasm-builder.cc b/src/asmjs/asm-wasm-builder.cc
index d6b88e00257a16ce89646e93ae9e796e2b241e7f..87f4ba553355990480dea6b1c2e1e143ed2bb16f 100644
--- a/src/asmjs/asm-wasm-builder.cc
+++ b/src/asmjs/asm-wasm-builder.cc
@@ -47,7 +47,7 @@ struct ForeignVariable {
class AsmWasmBuilderImpl final : public AstVisitor<AsmWasmBuilderImpl> {
public:
AsmWasmBuilderImpl(Isolate* isolate, Zone* zone,
- AstValueFactory* ast_value_factory, Script* script,
+ AstValueFactory* ast_value_factory, Handle<Script> script,
FunctionLiteral* literal, AsmTyper* typer)
: local_variables_(ZoneHashMap::kDefaultHashMapCapacity,
ZoneAllocationPolicy(zone)),
@@ -139,10 +139,10 @@ class AsmWasmBuilderImpl final : public AstVisitor<AsmWasmBuilderImpl> {
// SharedFunctionInfo to parse a single function,
// or squirrel away the SharedFunctionInfo to use later.
Handle<SharedFunctionInfo> shared =
- isolate_->factory()->NewSharedFunctionInfoForLiteral(
- decl->fun(), handle(script_, isolate_));
+ isolate_->factory()->NewSharedFunctionInfoForLiteral(decl->fun(),
+ script_);
shared->set_is_toplevel(false);
- ParseInfo info(&zone, handle(script_, isolate_));
+ ParseInfo info(&zone, script_);
info.set_shared_info(shared);
info.set_toplevel(false);
info.set_language_mode(decl->fun()->scope()->language_mode());
@@ -1921,7 +1921,7 @@ class AsmWasmBuilderImpl final : public AstVisitor<AsmWasmBuilderImpl> {
Isolate* isolate_;
Zone* zone_;
AstValueFactory* ast_value_factory_;
- Script* script_;
+ Handle<Script> script_;
AsmTyper* typer_;
bool typer_failed_;
ZoneVector<std::pair<BreakableStatement*, bool>> breakable_blocks_;
@@ -1940,7 +1940,7 @@ class AsmWasmBuilderImpl final : public AstVisitor<AsmWasmBuilderImpl> {
AsmWasmBuilder::AsmWasmBuilder(Isolate* isolate, Zone* zone,
AstValueFactory* ast_value_factory,
- Script* script, FunctionLiteral* literal)
+ Handle<Script> script, FunctionLiteral* literal)
: isolate_(isolate),
zone_(zone),
ast_value_factory_(ast_value_factory),
« no previous file with comments | « src/asmjs/asm-wasm-builder.h ('k') | test/cctest/asmjs/test-asm-typer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698