Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Side by Side Diff: src/asmjs/asm-js.cc

Issue 2552873003: [wasm][asm.js] Pass Script with Handle. (Closed)
Patch Set: re-enable tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/asmjs/asm-typer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/asmjs/asm-js.h" 5 #include "src/asmjs/asm-js.h"
6 6
7 #include "src/api-natives.h" 7 #include "src/api-natives.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/asmjs/asm-typer.h" 9 #include "src/asmjs/asm-typer.h"
10 #include "src/asmjs/asm-wasm-builder.h" 10 #include "src/asmjs/asm-wasm-builder.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 default: { UNREACHABLE(); } 147 default: { UNREACHABLE(); }
148 } 148 }
149 return false; 149 return false;
150 } 150 }
151 151
152 } // namespace 152 } // namespace
153 153
154 MaybeHandle<FixedArray> AsmJs::ConvertAsmToWasm(ParseInfo* info) { 154 MaybeHandle<FixedArray> AsmJs::ConvertAsmToWasm(ParseInfo* info) {
155 ErrorThrower thrower(info->isolate(), "Asm.js -> WebAssembly conversion"); 155 ErrorThrower thrower(info->isolate(), "Asm.js -> WebAssembly conversion");
156 wasm::AsmWasmBuilder builder(info->isolate(), info->zone(), 156 wasm::AsmWasmBuilder builder(info->isolate(), info->zone(),
157 info->ast_value_factory(), *info->script(), 157 info->ast_value_factory(), info->script(),
158 info->literal()); 158 info->literal());
159 Handle<FixedArray> foreign_globals; 159 Handle<FixedArray> foreign_globals;
160 auto asm_wasm_result = builder.Run(&foreign_globals); 160 auto asm_wasm_result = builder.Run(&foreign_globals);
161 if (!asm_wasm_result.success) { 161 if (!asm_wasm_result.success) {
162 DCHECK(!info->isolate()->has_pending_exception()); 162 DCHECK(!info->isolate()->has_pending_exception());
163 PrintF("Validation of asm.js module failed: %s\n", 163 PrintF("Validation of asm.js module failed: %s\n",
164 builder.typer()->error_message()); 164 builder.typer()->error_message());
165 return MaybeHandle<FixedArray>(); 165 return MaybeHandle<FixedArray>();
166 } 166 }
167 wasm::ZoneBuffer* module = asm_wasm_result.module_bytes; 167 wasm::ZoneBuffer* module = asm_wasm_result.module_bytes;
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 i::Object::GetProperty(module_object, single_function_name); 256 i::Object::GetProperty(module_object, single_function_name);
257 if (!single_function.is_null() && 257 if (!single_function.is_null() &&
258 !single_function.ToHandleChecked()->IsUndefined(isolate)) { 258 !single_function.ToHandleChecked()->IsUndefined(isolate)) {
259 return single_function; 259 return single_function;
260 } 260 }
261 return module_object; 261 return module_object;
262 } 262 }
263 263
264 } // namespace internal 264 } // namespace internal
265 } // namespace v8 265 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/asmjs/asm-typer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698