Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2552873003: [wasm][asm.js] Pass Script with Handle. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Pass Script with Handle. The asm-wasm-builder started allocating SharedFunctionInfos, this makes it bad we'd passed Script by pointer (due to ignorance). Switching to Handle<Script>. R=clemensh@chromium.org,titzer@chromium.org BUG=v8:5716 Committed: https://crrev.com/051bc1ec3e0ad4ba8cdb90196414bcb488e68880 Cr-Commit-Position: refs/heads/master@{#41529}

Patch Set 1 #

Patch Set 2 : re-enable tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M src/asmjs/asm-js.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/asmjs/asm-typer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/asmjs/asm-typer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/asmjs/asm-wasm-builder.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/asmjs/test-asm-typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
bradnelson
4 years ago (2016-12-06 15:00:44 UTC) #5
titzer
lgtm
4 years ago (2016-12-06 15:09:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552873003/20001
4 years ago (2016-12-06 15:12:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 15:29:15 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-06 15:29:31 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/051bc1ec3e0ad4ba8cdb90196414bcb488e68880
Cr-Commit-Position: refs/heads/master@{#41529}

Powered by Google App Engine
This is Rietveld 408576698