Don't CHECK in service manager when loading service from disk package

Don't CHECK in service manager when loading service from disk package

This was causing CHECK failures on chrome --mash startup when running official
builds. The StartWithFilePath() flow redirects through a delegate in the
chrome_mash case, so this code is OK in production for chrome_mash.

rockot@ is going to look into how to disable this code path for content but
allow it for chrome_mash.

BUG=669243, 649673
TEST=chrome --mash starts up in official builds

Committed: https://crrev.com/498cf62596b579862eac02e27bb85d734b51bbeb
Cr-Commit-Position: refs/heads/master@{#436451}

[James Cook, 2016-12-05 22:20:25]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-12-05 22:20:57]

jamescook@chromium.org changed reviewers:
+ rockot@chromium.org

[James Cook, 2016-12-05 22:20:57]

rockot, PTAL

[commit-bot: I haz the power, 2016-12-05 22:21:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-12-05 22:24:59]

lgtm

[James Cook, 2016-12-05 22:32:42]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-12-05 22:32:48]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-12-05 22:33:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 23:34:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480977168260780,
"parent_rev": "a7ddb61cee8e5de8434ec2919adb0fec55f8f31c", "commit_rev":
"2f37a455fd2ef1dd216770264f30755e8de178a0"}

[commit-bot: I haz the power, 2016-12-05 23:35:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 23:38:40]

Description was changed from

==========
Don't CHECK in service manager when loading service from disk package

This was causing CHECK failures on chrome --mash startup when running official
builds. The StartWithFilePath() flow redirects through a delegate in the
chrome_mash case, so this code is OK in production for chrome_mash.

rockot@ is going to look into how to disable this code path for content but
allow it for chrome_mash.

BUG=669243,649673
TEST=chrome --mash starts up in official builds
==========

to

==========
Don't CHECK in service manager when loading service from disk package

This was causing CHECK failures on chrome --mash startup when running official
builds. The StartWithFilePath() flow redirects through a delegate in the
chrome_mash case, so this code is OK in production for chrome_mash.

rockot@ is going to look into how to disable this code path for content but
allow it for chrome_mash.

BUG=669243,649673
TEST=chrome --mash starts up in official builds

Committed: https://crrev.com/498cf62596b579862eac02e27bb85d734b51bbeb
Cr-Commit-Position: refs/heads/master@{#436451}
==========

[commit-bot: I haz the power, 2016-12-05 23:38:41]

Patchset 2 (id:??) landed as
https://crrev.com/498cf62596b579862eac02e27bb85d734b51bbeb
Cr-Commit-Position: refs/heads/master@{#436451}