Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Side by Side Diff: remoting/test/chromoting_test_driver_environment.h

Issue 2552863002: Fixing uninitialized variable in CTD EnvironmentOptions struct (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_TEST_CHROMOTING_TEST_DRIVER_ENVIRONMENT_H_ 5 #ifndef REMOTING_TEST_CHROMOTING_TEST_DRIVER_ENVIRONMENT_H_
6 #define REMOTING_TEST_CHROMOTING_TEST_DRIVER_ENVIRONMENT_H_ 6 #define REMOTING_TEST_CHROMOTING_TEST_DRIVER_ENVIRONMENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 22 matching lines...) Expand all
33 public: 33 public:
34 struct EnvironmentOptions { 34 struct EnvironmentOptions {
35 EnvironmentOptions(); 35 EnvironmentOptions();
36 ~EnvironmentOptions(); 36 ~EnvironmentOptions();
37 37
38 std::string user_name; 38 std::string user_name;
39 std::string host_name; 39 std::string host_name;
40 std::string host_jid; 40 std::string host_jid;
41 std::string pin; 41 std::string pin;
42 base::FilePath refresh_token_file_path; 42 base::FilePath refresh_token_file_path;
43 bool use_test_environment; 43 bool use_test_environment = false;
44 }; 44 };
45 45
46 explicit ChromotingTestDriverEnvironment(const EnvironmentOptions& options); 46 explicit ChromotingTestDriverEnvironment(const EnvironmentOptions& options);
47 ~ChromotingTestDriverEnvironment() override; 47 ~ChromotingTestDriverEnvironment() override;
48 48
49 // Returns false if a valid access token cannot be retrieved. 49 // Returns false if a valid access token cannot be retrieved.
50 bool Initialize(const std::string& auth_code); 50 bool Initialize(const std::string& auth_code);
51 51
52 // Retrieves connection information for all known hosts and displays 52 // Retrieves connection information for all known hosts and displays
53 // their availability to STDOUT. 53 // their availability to STDOUT.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 153
154 // Unfortunately a global var is how the GTEST framework handles sharing data 154 // Unfortunately a global var is how the GTEST framework handles sharing data
155 // between tests and keeping long-lived objects around. Used to share access 155 // between tests and keeping long-lived objects around. Used to share access
156 // tokens and a host list across tests. 156 // tokens and a host list across tests.
157 extern ChromotingTestDriverEnvironment* g_chromoting_shared_data; 157 extern ChromotingTestDriverEnvironment* g_chromoting_shared_data;
158 158
159 } // namespace test 159 } // namespace test
160 } // namespace remoting 160 } // namespace remoting
161 161
162 #endif // REMOTING_TEST_CHROMOTING_TEST_DRIVER_ENVIRONMENT_H_ 162 #endif // REMOTING_TEST_CHROMOTING_TEST_DRIVER_ENVIRONMENT_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698