In aura mus, WindowManagerClient::AddAccelerator() should take an array.

In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow up for https://codereview.chromium.org/2520093003/

BUG=671229, 632049
Committed: https://crrev.com/68c719cc1ac847685d1a781ea00ef2b50761ad55
Cr-Commit-Position: refs/heads/master@{#436424}

[thanhph, 2016-12-05 17:18:57]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 17:19:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[thanhph, 2016-12-05 17:21:39]

Description was changed from

==========
Change AddAccelerator -> AddAccelerators for Aura mus.

BUG=671229
==========

to

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

BUG=671229
==========

[thanhph, 2016-12-05 17:22:43]

Description was changed from

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

BUG=671229
==========

to

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is the follow up change on
https://bugs.chromium.org/p/chromium/issues/detail?id=632049.

BUG=671229
==========

[thanhph, 2016-12-05 17:23:17]

Description was changed from

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is the follow up change on
https://bugs.chromium.org/p/chromium/issues/detail?id=632049.

BUG=671229
==========

to

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is the follow up change based on
https://bugs.chromium.org/p/chromium/issues/detail?id=632049.

BUG=671229
==========

[commit-bot: I haz the power, 2016-12-05 18:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 18:19:34]

Dry run: This issue passed the CQ dry run.

[thanhph, 2016-12-05 18:25:01]

thanhph@chromium.org changed reviewers:
+ mfomitchev@google.com, sky@chromium.org

[mfomitchev, 2016-12-05 20:08:31]

mfomitchev@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[mfomitchev, 2016-12-05 20:08:32]

LGTM with nits

I think it's better to reference the CL, not the bug in the CL description,
i.e.:

"This is a follow for https://codereview.chromium.org/2520093003"

If you want to reference the bug as well, you can add it under "BUG=". You can
have multiple bug numbers there, separated by commas.

https://codereview.chromium.org/2552783002/diff/1/ui/aura/mus/window_manager_...
File ui/aura/mus/window_manager_delegate.h (right):

https://codereview.chromium.org/2552783002/diff/1/ui/aura/mus/window_manager_...
ui/aura/mus/window_manager_delegate.h:17: #include
"services/ui/public/interfaces/event_matcher.mojom.h"
no longer needed I think?

[thanhph, 2016-12-05 20:15:59]

Description was changed from

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is the follow up change based on
https://bugs.chromium.org/p/chromium/issues/detail?id=632049.

BUG=671229
==========

to

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow for
https://bugs.chromium.org/p/chromium/issues/detail?id=632049.

BUG=671229,632049
==========

[thanhph, 2016-12-05 20:19:23]

On 2016/12/05 20:08:32, mfomitchev wrote:
> LGTM with nits
> 
> I think it's better to reference the CL, not the bug in the CL description,
> i.e.:
> 
> "This is a follow for https://codereview.chromium.org/2520093003%22
> 
> If you want to reference the bug as well, you can add it under "BUG=". You can
> have multiple bug numbers there, separated by commas.

Thanks Mikhail. I added another bug number and update text in the description.

[thanhph, 2016-12-05 20:19:45]

thanhph@chromium.org changed reviewers:
- mfomitchev@google.com

[thanhph, 2016-12-05 20:19:45]

https://codereview.chromium.org/2552783002/diff/1/ui/aura/mus/window_manager_...
File ui/aura/mus/window_manager_delegate.h (right):

https://codereview.chromium.org/2552783002/diff/1/ui/aura/mus/window_manager_...
ui/aura/mus/window_manager_delegate.h:17: #include
"services/ui/public/interfaces/event_matcher.mojom.h"
On 2016/12/05 20:08:32, mfomitchev wrote:
> no longer needed I think?

Done, thanks!

[thanhph, 2016-12-05 20:19:53]

The CQ bit was checked by thanhph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 20:20:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mfomitchev, 2016-12-05 20:20:43]

On 2016/12/05 20:19:45, thanhph wrote:
>
https://codereview.chromium.org/2552783002/diff/1/ui/aura/mus/window_manager_...
> File ui/aura/mus/window_manager_delegate.h (right):
> 
>
https://codereview.chromium.org/2552783002/diff/1/ui/aura/mus/window_manager_...
> ui/aura/mus/window_manager_delegate.h:17: #include
> "services/ui/public/interfaces/event_matcher.mojom.h"
> On 2016/12/05 20:08:32, mfomitchev wrote:
> > no longer needed I think?
> 
> Done, thanks!

You may have missed my comment regarding CL description.

[thanhph, 2016-12-05 20:28:50]

Description was changed from

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow for
https://bugs.chromium.org/p/chromium/issues/detail?id=632049.

BUG=671229,632049
==========

to

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow for https://codereview.chromium.org/2520093003/

BUG=671229,632049
==========

[thanhph, 2016-12-05 20:29:19]

Description was changed from

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow for https://codereview.chromium.org/2520093003/

BUG=671229,632049
==========

to

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow up for https://codereview.chromium.org/2520093003/

BUG=671229,632049
==========

[thanhph, 2016-12-05 20:30:40]

On 2016/12/05 20:20:43, mfomitchev wrote:
> On 2016/12/05 20:19:45, thanhph wrote:
> >
>
https://codereview.chromium.org/2552783002/diff/1/ui/aura/mus/window_manager_...
> > File ui/aura/mus/window_manager_delegate.h (right):
> > 
> >
>
https://codereview.chromium.org/2552783002/diff/1/ui/aura/mus/window_manager_...
> > ui/aura/mus/window_manager_delegate.h:17: #include
> > "services/ui/public/interfaces/event_matcher.mojom.h"
> > On 2016/12/05 20:08:32, mfomitchev wrote:
> > > no longer needed I think?
> > 
> > Done, thanks!
> 
> You may have missed my comment regarding CL description.

Done, I updated the description to add the cl link
https://codereview.chromium.org/2520093003/

[commit-bot: I haz the power, 2016-12-05 21:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 21:15:35]

Dry run: This issue passed the CQ dry run.

[sky, 2016-12-05 22:00:27]

LGTM

[thanhph, 2016-12-05 22:16:32]

The CQ bit was checked by thanhph@chromium.org

[thanhph, 2016-12-05 22:16:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mfomitchev@chromium.org
Link to the patchset: https://codereview.chromium.org/2552783002/#ps20001
(title: "Remove unused include.")

[commit-bot: I haz the power, 2016-12-05 22:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 22:24:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480976192542370,
"parent_rev": "7ff9b542eb8c5a1dfcb32d0a9adbe8796a57757e", "commit_rev":
"923cd9144e9d1c859729f575abbe45061abed380"}

[commit-bot: I haz the power, 2016-12-05 22:24:46]

Description was changed from

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow up for https://codereview.chromium.org/2520093003/

BUG=671229,632049
==========

to

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow up for https://codereview.chromium.org/2520093003/

BUG=671229,632049
==========

[commit-bot: I haz the power, 2016-12-05 22:24:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 22:27:29]

Description was changed from

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow up for https://codereview.chromium.org/2520093003/

BUG=671229,632049
==========

to

==========
In aura mus, WindowManagerClient::AddAccelerator() should take an array.

This is a follow up for https://codereview.chromium.org/2520093003/

BUG=671229,632049

Committed: https://crrev.com/68c719cc1ac847685d1a781ea00ef2b50761ad55
Cr-Commit-Position: refs/heads/master@{#436424}
==========

[commit-bot: I haz the power, 2016-12-05 22:27:30]

Patchset 2 (id:??) landed as
https://crrev.com/68c719cc1ac847685d1a781ea00ef2b50761ad55
Cr-Commit-Position: refs/heads/master@{#436424}