components/invalidation/DEPS - Issue 255273002: First step towards invalidations componentization

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/invalidation/DEPS

Issue 255273002: First step towards invalidations componentization (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 include_rules = [

	2 "+components/keyed_service",
	blundell 2014/05/05 08:48:41 These dependencies should be present in the gypfil These dependencies should be present in the gypfile as well. blundell 2014/05/05 08:48:41 There should be a -content rule here (see e.g. //c There should be a -content rule here (see e.g. //components/sync_driver/DEPS). rlarocque 2014/05/05 17:39:10 Added gyp dependencies for keyed_service and cache Show quoted text On 2014/05/05 08:48:41, blundell wrote: > These dependencies should be present in the gypfile as well. Added gyp dependencies for keyed_service and cacheinvalidation. rlarocque 2014/05/05 17:39:10 Done. I would have thought that "-content" was th Show quoted text On 2014/05/05 08:48:41, blundell wrote: > There should be a -content rule here (see e.g. //components/sync_driver/DEPS). Done. I would have thought that "-content" was the default for this directory.
	3

	4 "+google/cacheinvalidation",

	5

	6 "+sync/internal_api/public/base",

	7 "+sync/notifier",

	8 ]

OLD	NEW