Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2552723004: [ignition/turbofan] Wrap bytecode liveness bitvectors (Closed)

Created:
4 years ago by Leszek Swirski
Modified:
4 years ago
Reviewers:
Jarin, rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ignition/turbofan] Wrap bytecode liveness bitvectors Wrap the liveness bitvectors from the bytecode liveness analysis with a helper class, which makes the register/accumulator bits explicit. Committed: https://crrev.com/7b64e8d102bb80ed8a050f4b8d61d2759d4ee0e2 Cr-Commit-Position: refs/heads/master@{#41589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -89 lines) Patch
M src/bit-vector.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/bytecode-analysis.h View 1 chunk +5 lines, -11 lines 0 comments Download
M src/compiler/bytecode-analysis.cc View 18 chunks +50 lines, -44 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M src/compiler/bytecode-liveness-map.h View 1 chunk +77 lines, -13 lines 0 comments Download
M src/compiler/bytecode-liveness-map.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M test/unittests/compiler/bytecode-analysis-unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Leszek Swirski
Hi Ross, Here's the bytecode liveness wrapper we discussed in the bytecode analysis CL, that ...
4 years ago (2016-12-06 09:27:59 UTC) #4
rmcilroy
I actually like these changes, I think it makes the code which checks and uses ...
4 years ago (2016-12-08 09:41:47 UTC) #8
Jarin
lgtm. I like it!
4 years ago (2016-12-08 12:05:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552723004/1
4 years ago (2016-12-08 12:17:26 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 12:47:50 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 12:48:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b64e8d102bb80ed8a050f4b8d61d2759d4ee0e2
Cr-Commit-Position: refs/heads/master@{#41589}

Powered by Google App Engine
This is Rietveld 408576698