storage: Cleanup class/struct forward declarations

storage: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in storage header files.

BUG=662195
Committed: https://crrev.com/df1bd24ca731b2f45fac37d5b1cc422d9b968a66
Cr-Commit-Position: refs/heads/master@{#436550}

[jbriance, 2016-12-05 17:37:22]

jbriance@cisco.com changed reviewers:
+ dmurph@chromium.org, piman@chromium.org, tzik@chromium.org

[jbriance, 2016-12-05 17:37:22]

Thanks for reviewing:
- dmurph for storage/browser/blob
- tzik for storage/browser/fileapi and storage/browser/quota
- piman for storage/common/database/database_connections.h and
content/public/test/async_file_test_helper.h

[dmurph, 2016-12-05 19:19:23]

lgtm

[piman, 2016-12-05 20:01:12]

lgtm

[jbriance, 2016-12-05 20:50:43]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 20:51:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 21:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 21:54:31]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-12-06 05:46:09]

lgtm

[jbriance, 2016-12-06 07:04:23]

The CQ bit was checked by jbriance@cisco.com

[commit-bot: I haz the power, 2016-12-06 07:04:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 07:09:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 07:09:13]

Failed to apply patch for storage/browser/blob/blob_entry.h:
While running git apply --index -p1;
  error: patch failed: storage/browser/blob/blob_entry.h:22
  error: storage/browser/blob/blob_entry.h: patch does not apply

Patch:       storage/browser/blob/blob_entry.h
Index: storage/browser/blob/blob_entry.h
diff --git a/storage/browser/blob/blob_entry.h
b/storage/browser/blob/blob_entry.h
index
3c3869e89f4d9a8b8a382c74f59dd370f590c481..c8687352841f526f3029fe3b763790a1937626de
100644
--- a/storage/browser/blob/blob_entry.h
+++ b/storage/browser/blob/blob_entry.h
@@ -22,7 +22,6 @@
 namespace storage {
 class BlobDataHandle;
 class ShareableBlobDataItem;
-class ViewBlobInternalsJob;
 
 // This class represents a blob in BlobStorageRegistry. We export this only for
 // unit tests.

[jbriance, 2016-12-06 08:12:39]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-12-06 08:12:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org,
dmurph@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2552723003/#ps20001
(title: "Rebase on top of master")

[commit-bot: I haz the power, 2016-12-06 08:12:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 09:17:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481011959877420,
"parent_rev": "3df7bd6f511be99d96bd20e40a878c4d3c803671", "commit_rev":
"35b29dea4ef5bf517f24c6072aa3ba273dae7efb"}

[commit-bot: I haz the power, 2016-12-06 09:17:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-06 09:19:50]

Description was changed from

==========
storage: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in storage header files.

BUG=662195
==========

to

==========
storage: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in storage header files.

BUG=662195

Committed: https://crrev.com/df1bd24ca731b2f45fac37d5b1cc422d9b968a66
Cr-Commit-Position: refs/heads/master@{#436550}
==========

[commit-bot: I haz the power, 2016-12-06 09:19:52]

Patchset 2 (id:??) landed as
https://crrev.com/df1bd24ca731b2f45fac37d5b1cc422d9b968a66
Cr-Commit-Position: refs/heads/master@{#436550}