Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2552673004: Simplify blink_perf benchmark definitions (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
Zhen Wang, pdr.
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify blink_perf benchmark definitions Extract the common part into BlinkPerfBenchmark, so that for most of the benchmarks we need only 3 lines each. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/05a2d6dc76694d3958308cb40a97034e79268390 Cr-Commit-Position: refs/heads/master@{#436866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -132 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 5 chunks +40 lines, -132 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (7 generated)
Xianzhu
4 years ago (2016-12-06 18:07:24 UTC) #3
pdr.
On 2016/12/06 at 18:07:24, wangxianzhu wrote: > LGTM
4 years ago (2016-12-06 19:26:35 UTC) #5
Zhen Wang
lgtm
4 years ago (2016-12-06 21:54:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552673004/1
4 years ago (2016-12-07 01:33:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 04:58:46 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-07 05:00:38 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05a2d6dc76694d3958308cb40a97034e79268390
Cr-Commit-Position: refs/heads/master@{#436866}

Powered by Google App Engine
This is Rietveld 408576698