third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp - Issue 2552673002: Eagerly dispose of ScheduledActions (reland.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

Issue 2552673002: Eagerly dispose of ScheduledActions (reland.) (Closed)

Patch Set: Add assert Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

index 9c7f78faeceffe615dbb4bb5903cae7780f1e345..ef9de04c93d86c39c05801174a9a7f717a3a732b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

@@ -36,6 +36,13 @@ ScriptSourceCode::ScriptSourceCode(ScriptStreamer* streamer,

ScriptSourceCode::~ScriptSourceCode() {}

+void ScriptSourceCode::dispose() {

+ m_source = String();

+ m_resource = nullptr;

+ m_streamer = nullptr;

+ m_url = KURL();

DEFINE_TRACE(ScriptSourceCode) {

visitor->trace(m_resource);

visitor->trace(m_streamer);