Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

Issue 2552673002: Eagerly dispose of ScheduledActions (reland.) (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
index 9c7f78faeceffe615dbb4bb5903cae7780f1e345..ef9de04c93d86c39c05801174a9a7f717a3a732b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
@@ -36,6 +36,13 @@ ScriptSourceCode::ScriptSourceCode(ScriptStreamer* streamer,
ScriptSourceCode::~ScriptSourceCode() {}
haraken 2016/12/05 10:53:27 Add a dcheck to check that dispose has been called
sof 2016/12/05 10:54:51 No, that wouldn't be appropriate -- ScriptSourceCo
+void ScriptSourceCode::dispose() {
+ m_source = String();
+ m_resource = nullptr;
+ m_streamer = nullptr;
+ m_url = KURL();
+}
+
DEFINE_TRACE(ScriptSourceCode) {
visitor->trace(m_resource);
visitor->trace(m_streamer);

Powered by Google App Engine
This is Rietveld 408576698