Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2552643002: [wasm] Add disassembly for select instruction (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add disassembly for select instruction This was somehow missing so far. With this CL, we can disassembly all functions on AngryBots. R=titzer@chromium.org, rossberg@chromium.org BUG=chromium:659715 Committed: https://crrev.com/8f9bb9b8d6c0b7f2dfd68f4ed2ed67c539f77589 Cr-Commit-Position: refs/heads/master@{#41476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/wasm/wasm-text.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Clemens Hammacher
4 years ago (2016-12-05 09:35:00 UTC) #5
titzer
lgtm
4 years ago (2016-12-05 09:36:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2552643002/1
4 years ago (2016-12-05 09:40:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 09:42:40 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-05 09:43:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f9bb9b8d6c0b7f2dfd68f4ed2ed67c539f77589
Cr-Commit-Position: refs/heads/master@{#41476}

Powered by Google App Engine
This is Rietveld 408576698